Closed GoogleCodeExporter closed 9 years ago
sorry, ignore this. I had made some changes to the code which caused my
problems.
Original comment by vesterb...@gmail.com
on 2 Jul 2008 at 1:52
Original comment by chip...@gmail.com
on 2 Jul 2008 at 11:02
But, what is the reason for:
# We still want to show lines that contain only whitespace.
if temp != "":
line = temp
?
This will show "empty"/"space diff only" lines as yellow. That might not always
be
desirable.
It should also be an option if you want to do left strip only (as it is now),
or both
left and right strip, i.e., switch between
if self.ignore_space:
temp = line.lstrip()
and
if self.ignore_space:
temp = line.strip()
Original comment by vesterb...@gmail.com
on 3 Jul 2008 at 7:10
Example of whitespace-only lines shown as different => confusing if there are a
lot
of other changes as well.
Original comment by vesterb...@gmail.com
on 3 Jul 2008 at 7:12
Attachments:
You're saying any lines containing only whitespace show up as that? That's
certainly
not happening in any install I've seen. Maybe I don't understand.
Original comment by chip...@gmail.com
on 3 Jul 2008 at 7:25
Yes, whitespace only. Using trunk version of reviewboard, svn diff.
Original comment by vesterb...@gmail.com
on 3 Jul 2008 at 7:56
Original issue reported on code.google.com by
vesterb...@gmail.com
on 2 Jul 2008 at 1:47