Whitespace not ignored

[GoogleCodeExporter]

There is a bug in myersdiff.py in function _gen_diff_codes(self, lines).
The "temp" is never assigned to "line".

Change from:
                # We still want to show lines that contain only whitespace.
                if temp != "":
                    line = temp

To:

                # We still want to show lines that contain only whitespace.
                if temp != "":
                    line = temp

                line = temp

Original issue reported on code.google.com by vesterb...@gmail.com on 2 Jul 2008 at 1:47

[GoogleCodeExporter]

sorry, ignore this. I had made some changes to the code which caused my 
problems.

Original comment by vesterb...@gmail.com on 2 Jul 2008 at 1:52

[GoogleCodeExporter]

Original comment by chip...@gmail.com on 2 Jul 2008 at 11:02

• Changed state: UserError

[GoogleCodeExporter]

But, what is the reason for:

                # We still want to show lines that contain only whitespace.
                if temp != "":
                    line = temp

?

This will show "empty"/"space diff only" lines as yellow. That might not always 
be
desirable. 

It should also be an option if you want to do left strip only (as it is now), 
or both
left and right strip, i.e., switch between

 if self.ignore_space:
                temp = line.lstrip()

and 

 if self.ignore_space:
                temp = line.strip()

Original comment by vesterb...@gmail.com on 3 Jul 2008 at 7:10

[GoogleCodeExporter]

Example of whitespace-only lines shown as different => confusing if there are a 
lot
of other changes as well.

Original comment by vesterb...@gmail.com on 3 Jul 2008 at 7:12

Attachments:

• snapshot1.png

[GoogleCodeExporter]

You're saying any lines containing only whitespace show up as that? That's 
certainly
not happening in any install I've seen. Maybe I don't understand.

Original comment by chip...@gmail.com on 3 Jul 2008 at 7:25

[GoogleCodeExporter]

Yes, whitespace only. Using trunk version of reviewboard, svn diff.

Original comment by vesterb...@gmail.com on 3 Jul 2008 at 7:56