post-review does not include new files w/ CVS

*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
None.

What steps will reproduce the problem?
1. cvs add somefile
2. post-review
3.

What is the expected output? What do you see instead?
Expect to see newly added file in review request's diffs.
Instead, that file is not included.

What operating system are you using? What browser?
Linux, Firefox.

Please provide any additional information below.
This can be fixed easily by adding "-N" to the "cvs diff"
command.  Here is the one line patch which fixes the problem for me.

 Index: contrib/tools/post-review
===================================================================
--- contrib/tools/post-review   (revision 1357)
+++ contrib/tools/post-review   (working copy)
@@ -520,7 +520,7 @@

     def do_diff(self, params):
         # Diff returns "1" if differences were found.
-        return execute('cvs diff -u %s' % params,
+        return execute('cvs diff -uN %s' % params,
                        extra_ignore_errors=(1,))

I'll try to enter this as a code review request too.

Original issue reported on code.google.com by unk...@gmail.com on 8 Jul 2008 at 11:03

sureshvv / reviewboard

post-review does not include new files w/ CVS #533