sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard
0 stars 0 forks source link

Fix for CVS error "Absolute Module Reference Invalid" #535

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Pretty simple fix attached.  Full details are here:

http://groups.google.com/group/reviewboard/browse_thread/thread/d5fa15a9e93ef6a2

--Tony

Original issue reported on code.google.com by Tony.Bi...@gmail.com on 10 Jul 2008 at 1:54

Attachments:

GoogleCodeExporter commented 9 years ago
Found two other problems:

1. If the path component of the cvs root isn't doesn't end with a '/', the 
resulting
file name will begin appear to be an absolute path, which CVS doesn't like.

2. If the files are in an 'Attic' directory, the 'Attic/' component of the path 
needs
to be removed.

The attached diff incorporates Tony's diff above and the changes I made for (1) 
and (2).

--mcc

Original comment by matt.mcc...@gmail.com on 10 Jul 2008 at 6:15

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in r1394.

Original comment by trowb...@gmail.com on 12 Jul 2008 at 10:05

GoogleCodeExporter commented 9 years ago
Sounds like this broke again.

Original comment by chip...@gmail.com on 23 Feb 2011 at 7:22

GoogleCodeExporter commented 9 years ago
I haven't actually seen any additional bug reports or +1s on existing reports 
related to this in the last 2 years.

Original comment by trowb...@gmail.com on 11 Jun 2011 at 10:50

GoogleCodeExporter commented 9 years ago
This is definitely broken in 1.6.1 using a newer version of cvsnt and its diff 
to generate the file:

Concurrent Versions System (CVSNT) 2.8.01 (Soolin) Build 4269 (client/server)

Copyright (c) 1989-2001 Brian Berliner, david d `zoo' zuhn,
                        Jeff Polk, and other authors
CVSNT version (Sep  2 2011) Copyright (c) 1999-2009 Tony Hoyle and others
see http://www.cvsnt.org

Original comment by geckert....@gmail.com on 8 Nov 2011 at 9:12