sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard
0 stars 0 forks source link

Mercurial (hg) scmtools back end does not support file paths with spaces #541

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The Mercurial diff parser currently assumes that files do not have spaces.
This has caused us problems, as we have some files with spaces that need
review.

The attached patch enabled this to work properly in our environment using a
Debian-based server with Python 2.5.2. I will put this on the reviewboard
server shortly.

Original issue reported on code.google.com by dereksla...@gmail.com on 16 Jul 2008 at 8:39

Attachments:

GoogleCodeExporter commented 9 years ago
http://reviews.review-board.org/r/451/

Original comment by dereksla...@gmail.com on 16 Jul 2008 at 8:51

GoogleCodeExporter commented 9 years ago
I needed the exact same thing.

Updated patch below

Original comment by bboissin on 29 Jul 2008 at 10:42

Attachments:

GoogleCodeExporter commented 9 years ago
(sorry I don't know how to put the interdiff in review board :/ )

Original comment by bboissin on 29 Jul 2008 at 10:43

GoogleCodeExporter commented 9 years ago
And sorry, I messed up. The first hunk is unrelated (it's encoding related).

proper file is attached.

Original comment by bboissin on 29 Jul 2008 at 10:45

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks bboissin, I am getting destroyed at work right now and wasn't going to 
get to
that any time soon.

I updated the review request with your changes.

Original comment by dereksla...@gmail.com on 30 Jul 2008 at 12:52

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 15 Aug 2008 at 5:44