sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard
0 stars 0 forks source link

Cannot view diffs of files added to a branch (but not the trunk) in CVS #542

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When I attempt to view the diff that was created from a file added to a
branch in CVS, I get a FileNotFoundError.

The problem is that files added to a branch (and not the trunk) are put in
the 'attic' in the repository, which shows up as part of the pathname in
the patch.  For example, if file foo.c is added to the frobnitz module on
the bobo branch, the RCS file entry in path in the patch file will look
like this:

RCS file: /cvs_root_dir/frobnitz/Attic/foo.c,v

CVSClient is cvs.py is stripping the repository directory and the ','v
suffix, but leaving the '/Attic/' component of the path, which is what
causes the FileNotFound error.

I've attached a diff of cvs.py which fixes this issue.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What operating system are you using? What browser?

Please provide any additional information below.

Original issue reported on code.google.com by matt.mcc...@gmail.com on 17 Jul 2008 at 3:20

Attachments:

GoogleCodeExporter commented 9 years ago
In future, please submit patches at http://reviews.review-board.org/

Committed as r1519. Thanks!

Original comment by trowb...@gmail.com on 28 Sep 2008 at 11:38