post-review not working under Windows with SVN

[GoogleCodeExporter]

Locale fix (r1390) breaks windows compatibility.

r1390 makes post-review unusable for svn under windows.
It was reviewed here:
http://reviews.review-board.org/r/419/

What steps will reproduce the problem?
Try to use a post r1390 post-review under windows.

What is the expected output? What do you see instead?

It's expected to work:)
It'll fail "silently" instead with:
"The current directory does not contain a checkout from a
supported source code repository."

After adding some debugging:
"'env' is not recognized as an internal or external command,
operable program or batch file."

Original issue reported on code.google.com by mate.sza...@gmail.com on 17 Jul 2008 at 6:45

[GoogleCodeExporter]

I think the solution is simple.
Simply revert all the changes made in r1390.

Original comment by mate.sza...@gmail.com on 7 Aug 2008 at 3:24

[GoogleCodeExporter]

Pending review at http://reviews.review-board.org/r/515/

Original comment by chip...@gmail.com on 25 Aug 2008 at 10:53

• Added labels: Component-Scripts, Milestone-Release1.0, PendingReview, Priority-Critical
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Fixed in r1455.

Original comment by chip...@gmail.com on 27 Aug 2008 at 9:25

• Changed state: Fixed
• Removed labels: PendingReview

[GoogleCodeExporter]

The version at r1388 works for me but r1455 does not work.

I'm using SVN for source control.

It fails with '
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.
'

with --debug '
Error uploading diff: One or more fields had errors (105)
>>> {u'fields': {u'path': [u'The diff file is empty']}, u'stat': u'fail', u'err'
: {u'msg': u'One or more fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.
'

Original comment by andrewha...@gmail.com on 8 Sep 2008 at 9:38

[GoogleCodeExporter]

That's a separate bug most likely.

What happens when you run with --output-diff?

Original comment by chip...@gmail.com on 8 Sep 2008 at 10:26

• Changed state: NeedInfo

[GoogleCodeExporter]

Looks different.  Please open another bug with the details (if you can).

Original comment by trowb...@gmail.com on 23 Sep 2008 at 5:56

• Changed state: Fixed