web services doesn't strip newline from summary. new lines in summary cause publish to fail

sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard

0 stars 0 forks source link

web services doesn't strip newline from summary. new lines in summary cause publish to fail #548

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

I was able to create a review request that had a summary which contained new 
lines.  When the 
reviewer did a review and said "ship it" the publish failed.  I've attached the 
output of the failure 
which shows django's debug page.  

Jay

Original issue reported on code.google.com by jaybuffi...@gmail.com on 18 Jul 2008 at 6:29

Attachments:

rb-publish-fail.html

GoogleCodeExporter commented 9 years ago

Sorry, i forgot to mention i created the review request via web services.

Original comment by jaybuffi...@gmail.com on 18 Jul 2008 at 6:29

GoogleCodeExporter commented 9 years ago

We should either normalize the input, or send an error message.

Original comment by chip...@gmail.com on 19 Jul 2008 at 8:05

Added labels: Component-API, Milestone-Release1.0

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 29 Sep 2008 at 11:08

Changed state: Started

GoogleCodeExporter commented 9 years ago

Fixed in SVN r1520. Thanks!

Original comment by trowb...@gmail.com on 30 Sep 2008 at 12:05

Changed state: Fixed