sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard
0 stars 0 forks source link

Can not put comments before publishing review #550

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Post a review
2. Try to post a comment on any line

What is the expected output? What do you see instead?
Not able to post a comment. When "Save Comment" button is pressed message
"Not Found" is displayed at the bottom of Comments window but nothing happens.

What operating system are you using? What browser?
Red Hat Linux
Firefox

Please provide any additional information below.

Original issue reported on code.google.com by ksang...@gmail.com on 21 Jul 2008 at 10:44

GoogleCodeExporter commented 9 years ago
Make sure you're logged in and that the review request is published.

Original comment by chip...@gmail.com on 21 Jul 2008 at 11:22

GoogleCodeExporter commented 9 years ago
Uhh, Christian, read the summary?

Original comment by trowb...@gmail.com on 21 Jul 2008 at 11:25

GoogleCodeExporter commented 9 years ago
I did. The suggestions still apply. If you're not logged in, you can get the 
"Not
Found," and if you're logged in but the review request has been discarded, you 
can
also get it.

Original comment by chip...@gmail.com on 21 Jul 2008 at 11:46

GoogleCodeExporter commented 9 years ago
Could the NOT FOUND text be changed to "YOU ARE NOT LOGGED IN" or "THIS REVIEW 
HAS
NOT BEEN PUBLISHED"

Original comment by jeremy.b...@gmail.com on 15 Aug 2008 at 6:17

GoogleCodeExporter commented 9 years ago
Yeah, I think what we need to do is either show a login form or a link to the 
login
page when the user isn't logged in. We definitely need to show something when 
the
review hasn't been published as well. I'd like to get to this for 1.0.

Original comment by chip...@gmail.com on 15 Aug 2008 at 6:33

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 28 Sep 2008 at 8:55

GoogleCodeExporter commented 9 years ago
I've definitely seen this, even when the user in question is logged in.

Original comment by trowb...@gmail.com on 28 Dec 2008 at 9:01

GoogleCodeExporter commented 9 years ago
I don't think we'll see this anymore, since the entire codebase for commenting 
has
been completely rewritten, as has the UI, and some operations that may have 
caused
this in the first place are gone. The code for saving comments has also become 
a bit
more bullet-proof.

I'm going to close this. Please reopen if it happens with the new UI.

Original comment by chip...@gmail.com on 28 Dec 2008 at 10:20