sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard
0 stars 0 forks source link

If base diff path is missing for new review, path to diff disappears #553

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
http://demo.review-board.org/r/new/

What steps will reproduce the problem?
1. Repo- Navi, Base path- empty, Diff- path to some diff.
2. Click create review request.

What is the expected output? What do you see instead?
Expect to see error message and still have diff path filled in.
Instead both boxes are empty (and I get the error message).

What operating system are you using? What browser?
Linux, Firefox 3.

Original issue reported on code.google.com by dbenamy on 25 Jul 2008 at 2:33

GoogleCodeExporter commented 9 years ago
This is an RFE more than a defect. I don't see how to change the type though.

Original comment by dbenamy on 25 Jul 2008 at 2:34

GoogleCodeExporter commented 9 years ago
Sadly, Google Code doesn't let users set the type of report (yet).

I'd say it is more of a bug though. We should be able to fix it without too 
much trouble.

Marking this as a 1.0 fix, but we can push back to 1.5 if we need to.

Original comment by chip...@gmail.com on 31 Jul 2008 at 8:49

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 21 Sep 2008 at 2:16

GoogleCodeExporter commented 9 years ago
On the web server side, do we have the path on the user's disk? I didn't think 
so,
which makes this hard to do.

Original comment by trowb...@gmail.com on 18 Oct 2008 at 2:35

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 18 Oct 2008 at 2:36

GoogleCodeExporter commented 9 years ago
Looking through the documentation, we don't have the full path, only the 
filename.
This is reasonable, given the security/privacy implications here.

Unfortunately, this means we can't fix this.

Original comment by trowb...@gmail.com on 28 Dec 2008 at 7:59