sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard
0 stars 0 forks source link

diffviewer.js Incorrect URL #556

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
http://demo.review-board.org/r/707/diff/

What steps will reproduce the problem?
Any diff view

What is the expected output? What do you see instead?
When you put mouse on a line without comments, it should display comment-
ghost.png, however the url is wrong and this image is missing.

What operating system are you using? What browser?
Windows XP, Opera and IE7 tested

Please provide any additional information below.
Index: htdocs/media/rb/scripts/diffviewer.js
===================================================================
--- htdocs/media/rb/scripts/diffviewer.js       (revision 1414)
+++ htdocs/media/rb/scripts/diffviewer.js       (working copy)
@@ -657,7 +657,7 @@
                 gGhostCommentFlag = dh.append(document.body, {
                     id: 'ghost-commentflag',
                     tag: 'img',
-                    src: '../images/comment-ghost.png'
+                    src: MEDIA_URL + 'rb/images/comment-ghost.png'
                 }, true);
                 gGhostCommentFlag.enableDisplayMode();
                 gGhostCommentFlag.setAbsolutePositioned();

Original issue reported on code.google.com by thinkfly@gmail.com on 27 Jul 2008 at 3:24

GoogleCodeExporter commented 9 years ago
Fixed in r1425. Thanks!!

Original comment by trowb...@gmail.com on 2 Aug 2008 at 8:01