Indicate line termination

[GoogleCodeExporter]

reviewboard seems to completely ignore changes in line termination even
though the changes in the svn repository do show the line termination as
changing.

For me this would be a much more useful use of big bold red at the end of
line rather than showing it for trailing whitespace which can be shown in
other ways.

Another idea is to pick the line ending most typically used in the file CR
or CRLF and highlight when the line ending is different.  Indicate the
expected line ending in a header or footer for each file.

Original issue reported on code.google.com by cord...@gmail.com on 29 Jul 2008 at 9:06

[GoogleCodeExporter]

Original comment by chip...@gmail.com on 27 Aug 2008 at 10:51

• Added labels: Component-DiffViewer, Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Original comment by trowb...@gmail.com on 18 Oct 2008 at 2:36

• Changed state: Confirmed

[GoogleCodeExporter]

This would actually be a *lot* of work and add overhead to the diff viewer, and 
while
I can see it being useful, I think it's only useful in a few situations under 
just
the right conditions. We'd have to replace all of our newline normalization 
code in
both post-review and Review Board's diff viewer, and doing this would likely 
regress
us quite a bit.

So after further thought, I'm going to have to say no to this one. Too much 
effort
and chance of breakages for too little reward.

Original comment by chip...@gmail.com on 11 Oct 2009 at 4:09

• Changed state: WontFix