search

sureswiftcapital / WP-Google-Calendar-Events

Legacy version/fork of the Google Calendar Events 2.4 WordPress plugin. Intended for backwards compatibility only.
https://wordpress.org/plugins/legacy-google-calendar-events/
29 stars 18 forks source link

Replace ThickBox with Magnific Popup #53

Closed unfulvio closed 8 years ago

unfulvio commented 9 years ago

in 2.x and 3.x the Add Shortcode button uses ThickBox which comes preloaded in WordPress edit post pages as it's used by the Media Uploader.

ThickBox is old as a dinosaur and it has been mangled for internal WordPress purposes anyway. A lot of people writing media buttons hack ThickBox to add buttons next to Add Media button in the Editor.

Not urgent, but in future it'd be better to replace this with another modal and lightweight jQuery plugin, perhaps Magnific Popup.

pderksen commented 9 years ago

Looks like a great library. I already had it starred and it's obviously popular. If it's easier to work with a lighter weight then go for it.