surevelox / OrchardCore.Modules

Modules for Orchard Core CMS
https://surevelox.github.io/OrchardCore.Modules/
BSD 3-Clause "New" or "Revised" License
20 stars 4 forks source link

Exception after completing the first step of the sign up #52

Open MikeAlhayek opened 2 years ago

MikeAlhayek commented 2 years ago

after creating the registration steps and try to complete the first step, I get the following exception

An unhandled exception occurred while processing the request.
MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<!!0> YesSql.SessionExtensions.GetAsync(YesSql.ISession, Int32, System.String)'.

Surevelox.OrchardCore.Data.Store<T>.GetAsync(int id)

    Stack Query Cookies Headers Routing 

    MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<!!0> YesSql.SessionExtensions.GetAsync(YesSql.ISession, Int32, System.String)'.
        Surevelox.OrchardCore.Data.Store<T>.GetAsync(int id)
        a.U.BindModelAsync(ModelBindingContext bindingContext)
        Microsoft.AspNetCore.Mvc.ModelBinding.ParameterBinder.BindModelAsync(ActionContext actionContext, IModelBinder modelBinder, IValueProvider valueProvider, ParameterDescriptor parameter, ModelMetadata metadata, object value, object container)
        System.Runtime.CompilerServices.ValueTaskAwaiter<TResult>.GetResult()
        Microsoft.AspNetCore.Mvc.Controllers.ControllerBinderDelegateProvider+<>c__DisplayClass0_0+<<CreateBinderDelegate>g__Bind|0>d.MoveNext()
        Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, object state, bool isCompleted)
        Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, object state, bool isCompleted)
        Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
        Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
        Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|20_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, object state, bool isCompleted)
        Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker)
        Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker)
        Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
        SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.Invoke(HttpContext httpContext, bool retry)
        Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
        OrchardCore.Liquid.ScriptsMiddleware.Invoke(HttpContext httpContext)
        Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
        Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
        OrchardCore.Diagnostics.DiagnosticsStartupFilter+<>c__DisplayClass3_0+<<Configure>b__1>d.MoveNext()
        Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
        OrchardCore.Modules.ModularTenantRouterMiddleware.Invoke(HttpContext httpContext)
        OrchardCore.Modules.ModularTenantContainerMiddleware+<>c__DisplayClass4_0+<<Invoke>b__0>d.MoveNext()
        OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
        OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
        OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
        OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
        OrchardCore.Modules.ModularTenantContainerMiddleware.Invoke(HttpContext httpContext)
        Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

image

ns8482e commented 2 years ago

It seems version mismatching with dlls - fix will be available in next rc version

This is due to OC versioning is not truly following conventional commits ( https://www.conventionalcommits.org) in conventional commit feat is treated minor version upgrade, and braking changes are treated as major change. But in OC breaking changes are introduced between minor versions updates.

So Nuget thinks minor version upgrades are compatible, but they are really not

Related issue OrchardCore#12827

ns8482e commented 2 years ago

@MikeAlhayek Fix is available in 1.5.0-rc-20221117.6