search

surevine / govuk-react-jsx

govuk-frontend compatible React components
https://govuk-react-jsx.netlify.app/
MIT License
3 stars 0 forks source link

Rename Header serviceUrl and homepageUrl props to create html link or router link #60

Closed andymantell closed 4 years ago

andymantell commented 4 years ago

homepageUrl and serviceUrl have become homepageUrlHref / homepageUrlTo and serviceUrlHref / serviceUrlTo, with the To variants being passed to a react-router <Link> the Href variants being a plain html <a> tag

Fixes #21

neb42 commented 4 years ago

Thanks @andymantell. This looks good and solves the issue I was having.

andymantell commented 4 years ago

Great thanks @neb42. I'll get this released in a moment. It'll be a major version bump to 2.0.0 since it's a breaking change.

andymantell commented 4 years ago

@neb42 This has been released now as govuk-react-jsx@2.0.0 on npmjs.com. Any problems let me know.

neb42 commented 4 years ago

Thanks @andymantell !