search

surface-security / django-notification-sender

Django App to let users configure a notification system in Surface. Supports Email and Slack
MIT License
1 stars 1 forks source link

slack-sdk #13

Closed fopina closed 1 year ago

fopina commented 1 year ago

https://github.com/surface-security/django-notification-sender/blob/79aabf43cd1eead53ff4f1b5a812f6d97515524b/setup.cfg#L34

@gsilvapt why was the version increased? Is this newer version required?

Because it can (and it does, with django-slack-processor) introduce dependency conflicts. IMO we should only increase dependency versions if a feature in the package requires that. Otherwise, the widest range possible should be used.

gsilvapt commented 1 year ago

No reason, my mistake. Reverted in #14.