surface-security / django-surface-theme

django admin theme based on https://appseed.us/admin-dashboards/django-dashboard-atlantis-dark
MIT License
3 stars 4 forks source link

remove SURFACE_MENU_ITEMS that user has no permission (UX) #23

Open fopina opened 1 year ago

fopina commented 1 year ago

To fix #20

Draft as tests are missing

codecov-commenter commented 1 year ago

Codecov Report

Base: 29.56% // Head: 29.18% // Decreases project coverage by -0.39% :warning:

Coverage data is based on head (e432096) compared to base (e1fbc3c). Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== - Coverage 29.56% 29.18% -0.39% ========================================== Files 9 9 Lines 531 538 +7 ========================================== Hits 157 157 - Misses 374 381 +7 ``` | [Impacted Files](https://codecov.io/gh/surface-security/django-surface-theme/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surface-security) | Coverage Δ | | |---|---|---| | [theme/utils.py](https://codecov.io/gh/surface-security/django-surface-theme/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surface-security#diff-dGhlbWUvdXRpbHMucHk=) | `14.70% <0.00%> (-0.45%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surface-security). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surface-security)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication