search

surface-ui / surface

A server-side rendering component library for Phoenix
https://surface-ui.org
MIT License
2.08k stars 150 forks source link

Tag 0.5.2 hasn't been pushed to GitHub, resulting in HexDocs links being broken #474

Closed hubertlepicki closed 3 years ago

hubertlepicki commented 3 years ago

The HexDocs pages have links that return 404, because of the tag that's not in GitHub.

Someone with admin rights to the repo could fix it by pushishing the v0.5.2 tag... please :)

For example, this page: https://hexdocs.pm/surface/Surface.LiveView.html links to this page that returns 404: https://github.com/surface-ui/surface/blob/v0.5.2/lib/surface/live_view.ex#L1

msaraiva commented 3 years ago

Done!

Thanks @hubertlepicki for pointing that out.

I'm also updating some of the docs for v0.5.2 to replace {{ ... }} with { ... }. We did that on master but it should have be done on the v0.5 branch too.

hubertlepicki commented 3 years ago

Yep, that was super confusing to me as well and I think I opened a separate issue but yes it totally makes sense to update this - or push a v0.5.3 with these fixes, but I'll take either.

On Fri, Aug 6, 2021 at 2:14 PM Marlus Saraiva @.***> wrote:

Done!

Thanks @hubertlepicki https://github.com/hubertlepicki for pointing that out.

I'm also updating some of the docs for v0.5.2 to replace {{ ... }} with { ... }. We did that on master but it should have be done on the v0.5 branch too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/surface-ui/surface/issues/474#issuecomment-894218610, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAID6V543LAZE2ZQTLFWV3T3PGZXANCNFSM5BVVKZNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Hubert Łępicki phone: +48 694 161 264 email/Google+: @.*** Skype: hubert.lepicki

AmberBit Sp. z o. o. ul. Hetmańska 42 lok. 205 15-727 Białystok

AmberBit Sp. z o. o. jest wpisana do Rejestru Przedsiębiorców Krajowego Rejestru Sądowego prowadzonego przez Sąd Rejonowy w Białymstoku, XII Wydział Gospodarczy Krajowego Rejestru Sądowego. Kapitał zakładowy 20 000,00 zł opłacony w całości. EU VAT: PL5423228204, NIP: 5423228204, KRS: 0000439100, REGON: 200741641

msaraiva commented 3 years ago

@hubertlepicki I republished the docs for v0.5.2 with the related fixes.

Thanks again for reporting those issues.

hubertlepicki commented 3 years ago

This works perfectly. Quoting Jose here:

:blue_heart: :heart: :green_heart: :yellow_heart: :black_heart: :orange_heart: