Fix dialyzer issue in EExEngine

surface-ui / surface

A server-side rendering component library for Phoenix

https://surface-ui.org

MIT License

2.08k stars 150 forks source link

Fix dialyzer issue in EExEngine #655

Closed dvic closed 2 years ago

dvic commented 2 years ago

Fixes #654

dvic commented 2 years ago

I also added generated: true to the second block, because although my project didn't trigger that part, I think it suffers from the same problem.

msaraiva commented 2 years ago

@dvic thanks! ❤️

msaraiva commented 2 years ago

Hey @dvic! We're still getting those dialyzer errors even after the PR. We've made some changes that made the problem disappear for us. Can you check if that branch also solves it for you? https://github.com/surface-ui/surface/tree/v0.8

janwillemvd commented 2 years ago

@dvic is away this week, that's why I'm responding.

I can confirm that our dialyzer issue was gone since ffaef38f874d9e93e4a1bc4bb94f83f009b3be79.

Also, https://github.com/surface-ui/surface/tree/v0.8 doesn't give any dialyzer warnings or errors 💪🏻.

We're still on LV 0.17 with this project.