surfacepatterns / synthclone

Other
42 stars 10 forks source link

Running make fails on Ubuntu 23.10 #26

Open hellocatfood opened 9 months ago

hellocatfood commented 9 months ago

Trying to install synthclone on Ubuntu 23.10 and, a while after running make, the compilation fails with the following error:

g++ -c -pipe -O2 -Wall -Wextra -D_REENTRANT -fPIC -DSYNTHCLONE_PLATFORM_UNIX -DQT_NO_DEBUG -DQT_PLUGIN -DQT_GUI_LIB -DQT_CORE_LIB -I../../include -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtGui -I/usr/include/x86_64-linux-gnu/qt5/QtCore -I../../../make/plugins/sfz -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o ../../../make/plugins/sfz/participant.o participant.cpp
In file included from participant.h:27,
                 from participant.cpp:25:
targetview.h:25:10: fatal error: QtGui/QAction: No such file or directory
   25 | #include <QtGui/QAction>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [Makefile:609: ../../../make/plugins/sfz/participant.o] Error 1
make[3]: Leaving directory '/home/hellocatfood/Desktop/synthclone/src/plugins/sfz'
make[2]: *** [Makefile:257: sub-sfz-make_first] Error 2
make[2]: Leaving directory '/home/hellocatfood/Desktop/synthclone/src/plugins'
make[1]: *** [Makefile:92: sub-plugins-make_first-ordered] Error 2
make[1]: Leaving directory '/home/hellocatfood/Desktop/synthclone/src'
make: *** [Makefile:47: sub-src-make_first] Error 2
surfacepatterns commented 9 months ago

I'll take a closer look at this when I get a chance.

In the meantime, if you're compiling from the current master, then you'll need to link against qt6 instead of qt5. That'll mean you'll need to use the qmake from qt6 when calling the configure script. I don't remember the exact command offhand, but I'll post it here when I get a chance.

hellocatfood commented 9 months ago

Thanks. How would I tell configure to use qt6?

surfacepatterns commented 9 months ago

The configure line I've been using is:

./configure --debug --prefix=/usr --qmake='/usr/bin/qmake6'

Note that there might still be other issues lurking in synthclone related to Qt. I didn't maintain this application for a decade, so I expect there are some things that are still broken.

hellocatfood commented 9 months ago

Thanks for that, it now successfully builds but when I run synthclone it doesn't launch:

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted (core dumped

I'll keep an eye on this repository and check again after some updates

surfacepatterns commented 9 months ago

Thanks for that, it now successfully builds but when I run synthclone it doesn't launch:

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted (core dumped

I'll keep an eye on this repository and check again after some updates

That is not a problem I've seen. I'm able to start the app, load sessions, and, in general, interact in the application.

You mentioned you're building synthclone on Ubuntu 23.10. Is there anything unusual or interesting with respect to the environment you're building synthclone in?

hellocatfood commented 9 months ago

I recompiled and strangely the issue seems to have gone away. No idea what the problem could have been!

surfacepatterns commented 9 months ago

I recompiled and strangely the issue seems to have gone away. No idea what the problem could have been!

The fact that the problem just went away is a little scary. :(

I'm in the process of rewriting a bunch of code in synthclone. One of the things I'll be sure to do is add a handler that runs on unexpected termination that prints a stack trace so we have a better idea of where these problems reside.

Even if the problem never comes back, I appreciate that you reported the issue. Thank you. :)