surfbryce / beautiful-lyrics

Completely revolutionizes the Spotify Lyrics Experience by introducing Live Lyrics, Dynamic Backgrounds, and Immersive Views
723 stars 30 forks source link

[KNOWN ISSUE] NO LYRICS BUG #441

Closed surfbryce closed 2 days ago

surfbryce commented 3 weeks ago

Hey! This is a bug-report that I can refer everybody to for duplicates and so people understand what is going ON! This replaces #340.

Basically, here's what you can expect by the end of this month (or earlier!):

  1. More songs supporting syllable-sync support, existing syllable-synced songs becoming more accurate or detailed 2/ Cinema/Fullscreen views getting entirely new visual updates, abandoning the Spotify UI elements and going all custom, it should look extremely good!
  2. Improved developer experience, should be significantly easier for people to contribute and setup the extension!
  3. And finally, of course, the patch to support the newest versions of Spotify

Here is some conversation on the why/what/when:

From https://github.com/surfbryce/beautiful-lyrics/pull/410#issuecomment-2065557081

It's not that it is a difficult fix, it's just that this happened when I was in the middle of making major changes on my end, so I've already fixed it and have it working but I need to finish the rest of my big changes prior to making an official update. I'm hoping to get something out this month for it.

From https://github.com/surfbryce/beautiful-lyrics/pull/410#issuecomment-2065571421

If you mean the Development project-space, it's not entirely accurate, the cinema/fullscreen views using custom elements (instead of Spotifys) are in fact one of the big changes, but custom lyrics scrolling won't be included.

The other actual change that prevents me from updating right away is that I'm making more changes to how my lyrics service works, which should bring syllable synced lyrics to even more songs (or improve accuracy for those that already have it).

The other one is also permanently improving the repository so that it can be built easily and works for everybody right out of the gate.

So big changes that I'm hoping I can get done soon!

surfbryce commented 2 weeks ago

Hello! Just another update, I'm planning to put this out on May 1st! No exact time, but will probably be mid-day for me (so in PST timezone). If you really care you can do the conversion to your own timezone to figure out roughly when.

Lots of really great changes are being made and worked on and I'm very happy with how things are going, hope you all enjoy as much I do looking at it right now!

surfbryce commented 2 weeks ago

Another update for anybody checking this, it will be released sometime May 1st, some last minute changes are being made to make sure everything goes super well. So still coming out on the 1st but not guaranteed to be middle of the day for me, could be later.

I appreciate all the patience thank you!

surfbryce commented 2 weeks ago

Hello! Sorry for the delay, should be coming out today, ran into a couple of bugs from the changes I've made so working on getting those resolved first BEFORE I put out the update, thanks for the patience!

surfbryce commented 2 weeks ago

Hello AGAIN..... this is the final update I'm going to give prior to the release, it will ABSOLUTELY be coming out on Friday.

If you're curious as to what is delaying the release, it's primarily:

  1. Getting the new visuals looking correctly and having the effects the way I want them
  2. Making sure all the new client code is stable and accounts for every possible edge-case I want to support
  3. The new lyrics backend and fixing bugs in the new fetching algorithm

I've pretty much gotten through all of 1 & 2, so now its just 3 left for Friday.

Another thing is that delaying it till Friday gives me the chance to actually create marketing material for the update and other chore related items (like updating the README, creating instructional videos on the new stuff, etc).

So again, I really appreciate the patience, and I apologize for the delay, I hope you guys enjoy the new update when it comes out!

EDIT: Also just to clarify, Friday just means any time PST on Friday, it will most likely be Friday night for me when I put it out, so for some of you it'll already be Saturday, but I'm really aiming to make all of this right on the first try here!

ANOTHER EDIT: By Friday I meant May 3rd, again, this will most likely be out on May 4th for those of you not in the PST timezone, as it'll be released around late night time for me

surfbryce commented 2 weeks ago

Alright never mind, don't take any word for when this update will come out, turns out I'm actually NOT done with 1. and 2. and I'm still doing a lot of visual work on top of the backend work.

Just to give you guys some context, I own a game development studio and work on several large games, I manage multiple people, and do open source projects like this, so I spread myself super thin, so just be patient while I finish this all up.

Just for some context on what I did today: I primarily spent it making a custom animation system so that certain actions (most notably, liking/unliking a song) can have the animations that I'm seeing in my head, I was not expecting this to take all day but it did because I was trying to find the best and most optimized solution.

I am very much a person who tries to make everything as perfect as it can possibly be, so I hope that when this releases that effort really shines through.

There are some other things I am debating even including in this release that will be missing compared to the old cinema/fullscreen views, for example; adding a song to a playlist, going directly to the album that the song is from, and etc.

I really do want to get this out, so I feel like I'll have to skip on these additions and add them afterwards. It'll hamper the UX for a little while but I feel like it'll be worth it just to have the extension working.

Anyways, I apologize for potentially hyping up some of you for a release that didn't happen today (or the last few). I work on this alone, make all the decisions alone, and design this alone, and I fixate on having everything feel natural and just right (that alone takes a while no matter how many people you have working on something).

It also doesn't help that Spotify has put a limit on Lyrics now (or completely lock some people out), and Beautiful Lyrics is arguably the best option there is period. (even better than Spotify's own lyrics) So I understand the severity of the situation and of course I am working to my best ability to get things right.

Thanks again!

surfbryce commented 2 weeks ago

I'll also be opening up this conversation since the updates aren't particularly important anymore and the release will be something within the next few days reasonably, I'm probably guessing Monday or Sunday, we'll have to see. (Any comments that are just posting issues will be deleted, PLEASE stay on topic)

RabjamX2 commented 2 weeks ago

No rush, take your time with your process. I definitely understand what you mean when you say you are the type of person who wants to perfect everything. I find myself often not publishing projects just because I'm not satisfied.

Good luck with your game dev studio and thanks for making and maintaining this project! Also thanks for the updates on the update!

Nadipkuh commented 2 weeks ago

I suggest making a quick fix so that it can be used by users first, so you can work on the update more calmly, like the person at #340 did.

because the beautiful lyrics are still very good, its even beat the lyrics from Spotify itself and I am very grateful that you are still maintaining this project.

painfulbunny commented 2 weeks ago

You are completely fine! No need to apologise or justify as we're happy you're still working on this. Take as much time as you need. Personally, I would rather have it perfect and up to your standard than rush a release to keep everybody else happy.

iseeface commented 2 weeks ago

its oke, i can wait

surfbryce commented 2 weeks ago

@Nadipkuh I think I mentioned this elsewhere and I guess I didn't mention it here, but personally, I would rather just wait until this new update is ready. Splitting my focus to clone this repository, then go through and fix all the dependency issues, then fix the existing bugs and etc. I don't think is something reasonable for me to do this late into the development process and especially this close to release. Not to mention the GItHub isn't actually the code in the final release (there are a lot of problems here that are being addressed in this new update).

The good thing is, I don't feel rushed or anything making this update, I just set goals for myself and unfortunately cannot hit them at the moment because of unforeseen requirements/additions, so I may come across as disappointed in these updates. Rest assured I am developing this update in a calm manner, definitely enjoying myself for sure, just taking a little more time.

IF for some reason I can't get it out by at least Monday, then yeah, I'll probably take the time to do everything I said I didn't want to do just earlier in this post. But really hoping I don't have to resort to that lol

TheLyricalSystem commented 2 weeks ago

no rush, we can wait 👍

ayushmath07 commented 2 weeks ago

of course, take your time. The old version fix works perfectly fine for now. I'm excited about the visual improvements, but I'm patient and trust your process to make them perfect😊❤

Nadipkuh commented 2 weeks ago

@surfbryce I just don't want you to do this under pressure, fortunately if you remain relaxed in working on this update, we are very grateful that even though you don't get paid, you still carry out maintenance on this project, take care of yourself, don't do it in a hurry, so that it is in accordance with your expectations 😊

sikxystinky commented 2 weeks ago

the fact that normal lyrics are premium locked now wont affect anything right?

GAMINGCHATS commented 2 weeks ago

Wait what? Also, how are extensions updated? Do they need to have all of spicetify updated? I'm curios.

Jan64X commented 2 weeks ago

the fact that normal lyrics are premium locked now wont affect anything right?

dammit, more corporate greed, just what we needed

ooogerman commented 2 weeks ago

Wait what? Also, how are extensions updated? Do they need to have all of spicetify updated? I'm curios.

pretty srue it isnt even premium locked i have premium and i cant access regular lyrics

FiraliaDev commented 2 weeks ago

the fact that normal lyrics are premium locked now wont affect anything right?

Nah it won't, beautiful lyrics works separately and is currently fully functional in sidebar view even tho the lyrics page/full screen mode is broken. (Fyi also for those looking smth to tide them over while functionality is restored, just enable your sidebar! It's better than nothing)

bleghj commented 2 weeks ago

meow, good work :3

arya070104 commented 2 weeks ago

No Problem, Bro take your time because I have seen your work and its top notch and am excited to get Beautiful Lyrics Back.

Videogame-Oscar commented 2 weeks ago

yea take your time fixing this :D

GAMINGCHATS commented 2 weeks ago

the fact that normal lyrics are premium locked now wont affect anything right?

Nah it won't, beautiful lyrics works separately and is currently fully functional in sidebar view even tho the lyrics page/full screen mode is broken. (Fyi also for those looking smth to tide them over while functionality is restored, just enable your sidebar! It's better than nothing)

I guess lyrics-plus is tolerable for while this is getting worked on but beautfiul lyrics is VERY much worth waiting for, and I actually use a combination of lyrics-plus and the beautiful lyrics on the sidebar.

surfbryce commented 2 weeks ago

@sikxystinky like others have already mentioned, the (terrible) premium move Spotify made will NOT affect Beautiful Lyrics. The Lyrics are completely separate from Spotify and will not require you to have premium to get any lyrics.

There use to be a thing with Beautiful Lyrics where having Spotify would give you more lyrics if my service couldn't provide them to you, but that is removed in this next update and everyone will have the same access to lyrics no matter if you are premium or not.

surfbryce commented 2 weeks ago

@GAMINGCHATS You do not need to update Spicetify to update your extensions, although, some extensions will not work on certain versions of Spicetify, for Beautiful Lyrics it is ALWAYS recommended that you are on the latest version of BOTH Spotify AND Spicetify.

Most extensions - if they don't have an auto-updater builtin to them like Beautiful Lyrics does - update via Marketplace, when you launch Spotify, the Marketplace will get the latest versions of these extensions. The problem is that it can take Marketplace a while to get the updates for the extensions. So that's why Beautiful Lyrics has an auto-updater builtin, there will be a new auto-updater used for the next update, so for everybody on the CURRENT VERSION of Beautiful Lyrics, it will not auto-update and you WILL have to RELOAD SPOTIFY.

Hypious commented 2 weeks ago

When does the update come out?

surfbryce commented 2 weeks ago

@Hypious read any of the above messages I sent, there's no guarantee, but I've given an idea for when it may come out

zintuka commented 1 week ago

TEMPORARY FIX! Install old spotify version (1.32 and below) and block the update (highly recommend rollback-spotify on github)

Sans3108 commented 1 week ago

Don't pull a cyberpunk now, take your time :)

theJayTea commented 1 week ago

@surfbryce , we're so grateful for your work on this. Please take the time you need — don't spread yourself too thin :) PS: This extension has been the reason I stuck to Spotify haha, and it's made hundreds of hours of music more enjoyable.

HannistHK commented 1 week ago

Thank you so much for the effort you put in this, Spicetify community can never thank you enough for this o7

Max87153 commented 1 week ago

For anyone wondering, beautiful-lyrics CAN be installed in latest Spotify (as a temporary fix) You can check https://github.com/surfbryce/beautiful-lyrics/pull/410 this pull request, which will include a javascript file in the repository. (https://github.com/heheleo/beautiful-lyrics/blob/main/dist/beautiful-lyrics.js)

Move that file into C:\Users\user\AppData\Local\spicetify\Extensions, now fire up a terminal (cmd or powershell) and type "spicetify config extensions beautiful-lyrics.js". Once done, type "spicetify apply" and hit enter, it should reload Spotify, now head to Marketplace and download beautiful lyrics again. You will have 2 icons for the microphone, hit whichever and you should be able to see the lyrics, that's what worked for me and 9 other people. image

arya070104 commented 1 week ago

For anyone wondering, beautiful-lyrics CAN be installed in latest Spotify (as a temporary fix) You can check #410 this pull request, which will include a javascript file in the repository. (https://github.com/heheleo/beautiful-lyrics/blob/main/dist/beautiful-lyrics.js)

Move that file into C:\Users\user\AppData\Local\spicetify\Extensions, now fire up a terminal (cmd or powershell) and type "spicetify config extensions beautiful-lyrics.js". Once done, type "spicetify apply" and hit enter, it should reload Spotify, now head to Marketplace and download beautiful lyrics again. You will have 2 icons for the microphone, hit whichever and you should be able to see the lyrics, that's what worked for me and 9 other people. image

yes it working but i have a doubt can we fix this double buttons Screenshot 2024-05-06 003155

image

fahim12732 commented 1 week ago

beautiful lyrics background only showing on the half of the sidebar. Already did the work around.

Skärmbild 2024-05-05 214325

heheleo commented 1 week ago

beautiful lyrics background only showing on the half of the sidebar. Already did the work around.

Skärmbild 2024-05-05 214325

Hello, can you post more information about this issue in #410 (your spicetify version and your current theme), so I could look into it?

EnforcedPizza commented 1 week ago

For anyone wondering, beautiful-lyrics CAN be installed in latest Spotify (as a temporary fix) You can check #410 this pull request, which will include a javascript file in the repository. (https://github.com/heheleo/beautiful-lyrics/blob/main/dist/beautiful-lyrics.js)

Move that file into C:\Users\user\AppData\Local\spicetify\Extensions, now fire up a terminal (cmd or powershell) and type "spicetify config extensions beautiful-lyrics.js". Once done, type "spicetify apply" and hit enter, it should reload Spotify, now head to Marketplace and download beautiful lyrics again. You will have 2 icons for the microphone, hit whichever and you should be able to see the lyrics, that's what worked for me and 9 other people. image

isn't working for me

mikobeng commented 1 week ago

@arya070104 @Max87153

A reason that you have two lyric buttons could be that you have Beautiful Lyrics from the Marketplace, AND the hot-fix by heheleo installed at the same time.

Uninstall the Marketplace version for the time-being and that should fix it.

fahim12732 commented 1 week ago

solved the problem with half background not showing. Just installed NPV ambiance extension. It fixed the problem

Max87153 commented 1 week ago

@arya070104 @Max87153

A reason that you have two lyric buttons could be that you have Beautiful Lyrics from the Marketplace, AND the hot-fix by heheleo installed at the same time.

Uninstall the Marketplace version for the time-being and that should fix it.

I've tested it and if you uninstall Markeplace's, the extension itself doesn't work. (clarify: for most people) That is why if you install Markeplace's and extension it works.

note: for most people!! for me, i dont really mind having 2 buttons but if you mind just uninstall markeplace version and try

bodacious-bombini commented 1 week ago

@surfbryce Maybe it's because I've been burned by so many game releases coming out in a horribly bugged state, but I actually really prefer projects get delays nowadays! So keep delaying! Plus, we aren't paying for this, so I don't want you to lose sleep over this!

EliottSchrr commented 1 week ago

For those who have 2 icons, just uninstall BeautifulLyrics from the Marketplace, you have 2 instances (1 from the Marketplace which doesn't work and one from your local .js extension file) of BeautifulLyrics so yeah you have 2 different icons.

GAMINGCHATS commented 1 week ago

For those who have 2 icons, just uninstall BeautifulLyrics from the Marketplace, you have 2 instances (1 from the Marketplace which doesn't work and one from your local .js extension file) of BeautifulLyrics so yeah you have 2 different icons.

The following was stated by @Max87153 in a previous comment

I've tested it and if you uninstall Markeplace's, the extension itself doesn't work. (clarify: for most people) That is why if you install Markeplace's and extension it works.

note: for most people!! for me, i dont really mind having 2 buttons but if you mind just uninstall markeplace version and try

So what you said may or may not work for some people.

Wart050 commented 1 week ago

This is all super exciting; its like waiting for a progress bar that is at 99 to turn to 100. Anyway, I can't wait for the next update, GL!

surfbryce commented 1 week ago

Alright so, just letting everybody know that I didn't really do anything over Saturday/Sunday just because I had family over, HOWEVER, I did finish all the visual stuff I wanted to do in terms of animation/polishing, so that's out of the way.

Mainly doing code clean-up now for all the animation stuff done in code (because I coded this when super tired so it's more like "just get this done" type of code), going to look into adding the "add to playlist" button (since this is a mandatory for release). The good thing is that is the only visual thing left I really need to add for the extension code and shouldn't take more than a day.

Otherwise, will spend today on those two things and then also getting to work on the backend and fixing up some remaining bugs

HannistHK commented 1 week ago

I smell my GPU burning before the new version even released 😭

MRMANbot commented 1 week ago

For anyone wondering, beautiful-lyrics CAN be installed in latest Spotify (as a temporary fix) You can check #410 this pull request, which will include a javascript file in the repository. (https://github.com/heheleo/beautiful-lyrics/blob/main/dist/beautiful-lyrics.js)

Move that file into C:\Users\user\AppData\Local\spicetify\Extensions, now fire up a terminal (cmd or powershell) and type "spicetify config extensions beautiful-lyrics.js". Once done, type "spicetify apply" and hit enter, it should reload Spotify, now head to Marketplace and download beautiful lyrics again. You will have 2 icons for the microphone, hit whichever and you should be able to see the lyrics, that's what worked for me and 9 other people. image

worked for me

surfbryce commented 1 week ago

Alright another small update, Tuesday will be dedicated to "add to playlist" functionality and lyrics service work, after that, I'm hoping I can get it out Wednesday, obviously I'm still going to do my marketing work prior to the release, but typically that isn't a long period of time anyways.

Just for whoever cares, today; I cleaned-up the codebase, added in some extra edge-cases, and gathered all the information I need to implement the "add to playlist" functionality tomorrow, so shouldn't be hard at all to make it.

B4sicallyF0x commented 1 week ago

For me it's working. Ubuntu 24.04. Making the system very very slow btw

surfbryce commented 1 week ago

Alright…. another update!

Spent way too much time today trying to design a developer module to interface with the Spotify Library (the left side bar basically), originally the idea was that everything was going to be stored locally and you could get updated for when items were added to a playlist, and when playlist details (like name/description) were updated; but - the issue with that - is that playlists can change elsewhere completely (by another user for example) and so those playlist details wouldn’t throw an update signal because the change didn’t happen on our end.

So, I simplified the scope a little bit, still providing playlist added/removed signals and playlist path/sort-order changed signals: but now, playlist details/content retrieving is done through a function instead of storing it locally, so that we can get the latest information when we need it (important for permissions and etc.)

This will be one of the things other extension developers can also use from the Spices JSR package.

This set me back a day, so will do the visuals for this and backend work on Wednesday, going to add in some sort order functions as well, visually for the “add to playlist” feature it will use the most recent playlists.

Sort order functions will be a part of the Library module as well so developers can use pre-existing Spotify sorts

Release hopefully should be out Thursday or Friday now!

HannistHK commented 1 week ago

image