Closed ezShroom closed 1 year ago
I think this might be an issue with Spotify or your network as it seems to get the lyrics fine on my end;
Can you:
and finally screenshot everything from the console - this will help me figure out what's wrong. Although - unfortunately - if you have completely closed Spotify by the time you read this since having ran into this issue there might not be anything of use/help for me. If you keep this mode on and run into any other song that has this issue though immediately follow the steps I've written out and post the screenshots here!
Here's my DevTools log from just after launching Spotify.
@Shroom2020 Yeah unfortunately it has to be on a new song that also has this issue since the lyrics result is cached on your end and so it will always just return that.
However, what you can do is clear the cache.
If you go back to the Developer Tools and click on the Application tab, then expand the Cache Storage list item, and finally right click on the Beautiful Lyrics entry you can delete all the cached lyrics/track information.
Once you do this if you go to the same song again it should (hopefully in this instance) fail to get the lyrics; if it fails again please go to the console and screenshot everything you can get from it. There should be some errors there from my extension
Not that I see.
@Shroom2020 did you delete the Beautiful Lyrics cache? Before deleting the cache make sure you are on a different song, then delete the cache, close spotify, and then reopen Spotify and have the console open and ready. Then go to that song that is failing to load Lyrics for you.
@surfbryce This is all I see after I press play and go to the BeautifulLyrics page. None of it looks remotely useful.
@Shroom2020 Can you provide confirmation that you cleared the cache by deleting the BeautifulLyrics entry? I can't tell if I'm going in a conversation loop or not.
Can you also try checking out the Network tab and ticking the Fetch/XHR tab.
You should see at least one entry that looks like this;
If you click on it, screenshots of the "Headers" and "Response" tabs would be awesome.
The main thing is that if my backend doesn't have lyrics and Spotify does have line-synced lyrics than it'll use Spotifys lyrics. However, Gilded Lily actually does have lyrics from my backend. So in either case it should be loading them for you.
Those Spotify lyrics are retrieved on your end as well - which is why I'm figuring it's an issue with your Spotify client on your network.
@surfbryce Yes, I did clear the cache, restart Spotify, and everything. Here's what happened on the network side:
If I open this endpoint in a browser, it also shows absolutely nothing. The request is successful but I'm not getting anything of use back, it seems.
@Shroom2020 is this what appears for the Gilded Lily (Sped Up) song? I looked up the ISRC code you just shared (QM8QH2000855) and no song exists with that. Which should be impossible since every song is required to have an ISRC code when registered with Spotify/Apple Music.
The record code for Gilded Lily (Sped Up) is USQX92206421 and for the normal version its USQX92206420 and the slowed down version is USQX92206422.
If you clear the cache again and then load up the Gilded Lily song see if you see this at all. I don't think it's possible for us to see the requests Spotify is making unfortunately so I don't know whether or not the requests on that end are failing.
There's something very wrong happening on your end though - I just don't know what it is yet
@surfbryce I can't really comment on that then. I have even less of a clue of what Spotify, and your extension, is trying to do here.
One thing I'll note here though is that on ISRC Finder, the Spotify link shows me this:
However, the same cannot be said for directly inserting QM8QH2000855
with their reverse lookup feature:
USQX92206421
, on the other hand, does find it.
If I had to guess, this issue is not to do with your extension or my network - it's to do with how Spotify or an API you depend on reports it.
@Shroom2020 That's the one thing I'm not sure about then - because on my side Spotify is returning back to me the ISRC that matches up with the US country code. But for some reason it's returning QM (alternative US country-code) for you.
This is definitely an issue with Spotify if it's returning different ISRC code for the same track since I am using their API to get the track information (and in turn their ISRC code). I'll have to look and see if there are any other codes returned for that song which may help me get the right ISRC.
Is this the only song you've come across that has this issue btw? From the title you made it seem like it happens for other songs as well but this is the only one you presented so far. It'll be helpful if you are aware of any others that do this for you.
However, there is something I can do to fix this issue so at least it's able to get the Spotify line-synced lyrics for now. I'll just forcefully add the current song id until the lyrics-fetcher for the Spotify portion since it should always at the least be getting the Spotify lyrics for the current version of the song (obviously)
@surfbryce I have noticed it happen with other music, but I haven't kept track of exactly what it was. This is the only one I remember because I was looking forward to seeing how it looks with BeautifulLyrics.
Oh one more thing @Shroom2020 - what country are you using this from and do you have a VPN on per-chance? If you do what VPN is that country from?
I did a little research and it's possible that based on your country there may be a different registered variant of the song which causes it to have a different ISRC code... which is just weird but possible!
@surfbryce I'm from the UK. No VPN here.
I'm experiencing the same problem with the song "My Mother Told Me" by "The Hound + The Fox" (ISRC QZGWX2190998). As suggested, I have cleared all cache. I'm using Spotify in Ukraine without a VPN. Also, the Reverse Lookup feature in ISRC Finder works fine for that song. What I did was delete all Spicetify extensions, then uninstall Spicetify and Spotify, reinstall Spotify and Spicetify with only this extension, and faced the same problem. But as a bonus, I now have the "Now Playing View" function added, haha. Another thing I should mention is that I'm unable to scroll through the lyrics on the original Spotify lyrics tab
@MrGenia Actually in this case the extension is working as intended - I cannot trust static lyrics from Spotify because Spotify will often times show incorrect lyrics or lyrics from another song when it comes to text-based lyrics.
Although, even when using Spotify to view the original lyrics they aren't present for me so it seems like those are regionally licensed lyrics as well.
@surfbryce So how'll the resolution on this work?
@Shroom2020
In short, right now I get all the possible track-ids that have the current tracks ISRC; however, because the right ISRC isn't being returned for you - it's not including the current track-id being played - so the solution is to just forcefully add the current track-id so that it always gets the lyrics for the playing track.
This solution doesn't interfere with anything or mess with the priorities; it simply forces the current track-id to be in our spotify track selection if it doesn't exist yet so that we can always just fallback onto the Spotify lyrics (if they aren't static).
I've been extremely busy recently so I haven't been able to push out an update for Beautiful Lyrics yet; but, I already have this working and implemented on my end. I have to finish some other suggestions before I push out the update so please bear with me on this!
@Shroom2020 This fix should be published - sorry for not getting this out sooner. I was primarily waiting to publish once I've finished the other features I wanted to get to.
Let me know if this is still happening. I've updated the cache versions so that new lyrics and track information will be retrieved. Hopefully, the track-information helps out with the ISRC issue and the lyrics should let that new forced spotify track inclusion to work out and fix the issue you were encountering.
Will close this issue once it's been confirmed that it works.
@surfbryce whee it works!
It seems some music, even though it has long-standing entries in Musixmatch, will simply not have its lyrics detected by the extension's page. This happens with both the Marketplace and pure JS extension versions.