surfbryce / beautiful-lyrics

Completely revolutionizes the Spotify Lyrics Experience by introducing Live Lyrics, Dynamic Backgrounds, and Immersive Views
1.14k stars 50 forks source link

NPV Dynamic Background Covers all of Spotify #609

Closed appcreatorguy closed 5 months ago

appcreatorguy commented 5 months ago

I am from the United Kingdom

Version Spotify for Linux (Flatpak) v1.2.31.1205.g4d59ad7c Spicetify v2.36.11 Theme: catppuccin

Developer Tools Files Spotify.css.txt Spotify.html.txt

Screenshots of bug occuring image

Screenshot of Console Top Half of console: image Bottom Half of console: image

appcreatorguy commented 5 months ago

FYI, I've fully uninstalled all my marketplace extensions (using Marketplace.reset('extensions') in the console, and then reinstalled them all, including beatiful lyrics, so I should hopefully be on the latest version. image image

And these are the extensions I have manually installed in my spicetify config file: adblock.js | catppuccin-macchiato.js | shuffle+.js | keyboardShortcut.js | power-bar.js | keyboard-shortcuts.js

appcreatorguy commented 5 months ago

https://github.com/surfbryce/beautiful-lyrics/assets/14041410/c4340bd7-3caf-4922-895d-f1ead8015aa7

Here's a video of how to recreate the error too, if that helps.

appcreatorguy commented 5 months ago

Additionally, if I try to open the Now playing view sidebar, I get a similar error of the background overflowing to the main screen, as in #603.

surfbryce commented 5 months ago

@appcreatorguy I checked and #590 fixes the lyrics not appearing in the page view issue. However, that background overflow issue from #603, can you do the same bug reporting process that you did earlier but do it with the Now Playing view open?

That's really the only thing I need to fix that bug

appcreatorguy commented 5 months ago

Here's the console: image I noticed the failed error 403 GET request at the bottom appears about 4 times every time the now playing tab is opened. Here are the 2 files: Spotify.css.txt Spotify.html.txt Here's a screenshot of what the bug looks like for me for good measure: image

Let me know if you need any more information, I'm happy to provide it and to see this bug get fixed!

surfbryce commented 5 months ago

@appcreatorguy Thank you so much! Those 403 errors are actually from Spotify themselves, I'll take a look at the overflow issue soon, thank you again!

surfbryce commented 5 months ago

@appcreatorguy Thank you so much for reporting! Was able to replicate your issue with the files you provided and it was a super simple fix, thanks so much I really appreciate the report! Should be fixed in the next patch

appcreatorguy commented 5 months ago

No worries, glad I could help. Looking forward to getting my lyrics back!

AlfyQ commented 5 months ago

@appcreatorguy Thank you so much for reporting! Was able to replicate your issue with the files you provided and it was a super simple fix, thanks so much I really appreciate the report! Should be fixed in the next patch

Hey, so any idea on when the next patch will drop?