surfbryce / beautiful-lyrics

Completely revolutionizes the Spotify Lyrics Experience by introducing Live Lyrics, Dynamic Backgrounds, and Immersive Views
960 stars 38 forks source link

Fullscreen Mode in Vertical Broken #76

Open Zefa-161 opened 1 year ago

Zefa-161 commented 1 year ago

image I reinstalled spotify and spicetify with no other themes or extensions present

surfbryce commented 1 year ago

@Zefa-161 I don't have a vertical monitor and really can't put the effort into flipping the one I have. There are a few things that I can do to fix this but one of the main things preventing me from testing this is how the layout should look.

What would you expect from fullscreen in vertical mode? Would you just expect the information on the left to be smaller or would you expect it to be on top while the lyrics are below it? Or something else?

Zefa-161 commented 1 year ago

That's fair. I'd probably say like this one with the lyrics on the right although of course then that leaves a lot of negative space below and above but I feel like thats better than if it was above or below because then it's quite unnatural looking up or down like that on a vertical monitor. image Also sorry to be picky, I really do love the extension I think you've done a beatiful job, especially with the mesmerizing backgrounds but I also noticed in the sidebar the about me section doesn't have the transparency is that just to do with the connected image above it? image But yeah I love the mod keep up the good work and thanks for replying :)

surfbryce commented 1 year ago

@Zefa-161 Alright I'll look into seeing what I can do to make that look right then - it seems like my extension is already kind of achieving that but because the sizing is based off the height of the window its a little larger than it actually should be. The lyrics themselves also suffer from this when the width is a lot wider than the height. So I think these are just changes I should be making where they take into consideration the height and width and not just one or the other.

Also as for the artist card transparency Spotify made an update that changed that - it used to be transparent. I'll take a look into that as well

Zefa-161 commented 1 year ago

Thank you!

electricsteve commented 1 month ago

image So when I have it vertically (not as vertical as @Zefa-161) my other things are shown, is this intenden or a bug? Also when in fullscreen you cannot drag the window.