surfcodes / website

surf.codes documentations & landingpage website made with NextJS
https://surf.codes
Apache License 2.0
3 stars 0 forks source link

setup blog and smaller adjustments #4

Closed diepoe closed 3 years ago

diepoe commented 3 years ago

I just setup the blog with mdx and made some smaller (style) corrections. This isn’t perfect (f.e. I’ll create another layout for a mdx-blogpost in the future) but it’s working πŸ™‚.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/bridged/surf-website/CPQaYUdoqfpJq9bUzpGYsCriLvMb
βœ… Preview: https://surf-website-git-fork-haudraufhaun-main-bridged.vercel.app

GwonHeeJun commented 3 years ago

in my opinion, header is a global component, What do you think about moving the header from wrapper to _app.js?

diepoe commented 3 years ago

@GwonHeeJun Oh yeah, good idea, let me push a fix πŸ‘πŸ»

GwonHeeJun commented 3 years ago

Good! 😎 😎

diepoe commented 3 years ago

Fixed πŸ‘πŸ»

diepoe commented 3 years ago

When you forget hitting Comment after writing a comment πŸ™ˆ

GwonHeeJun commented 3 years ago

Fixed πŸ‘πŸ»

Good! Confirm please @softmarshmallow

softmarshmallow commented 3 years ago

LGTM