surfcodes / website

surf.codes documentations & landingpage website made with NextJS
https://surf.codes
Apache License 2.0
3 stars 0 forks source link

Style patch #6

Closed diepoe closed 3 years ago

diepoe commented 3 years ago

This PR does following:

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bridged/surf-website/9nD3FaV8NPyGg34DtAzzjBhdJhhN
✅ Preview: https://surf-website-git-fork-haudraufhaun-style-patch-bridged.vercel.app

softmarshmallow commented 3 years ago

LGTM

diepoe commented 3 years ago

I just wanted get feedback on my idea of using the fira code font for the code blocks (live demo can be found here)

softmarshmallow commented 3 years ago

I just wanted get feedback on my idea of using the fira code font for the code blocks (live demo can be found here)

Seems like very suiting font for code blocks. I'll Update the designs too. (Actually i was looking for something like this.) One concern might be the font loading performance - since ony in docs it uses almost 3 fontfaces. (this could be optimized later)

Let's go with it

Ref: https://github.com/tonsky/FiraCode

diepoe commented 3 years ago

I just wanted get feedback on my idea of using the fira code font for the code blocks (live demo can be found here)

Seems like very suiting font for code blocks. I'll Update the designs too. (Actually i was looking for something like this.) One concern might be the font loading performance - since ony in docs it uses almost 3 fontfaces. (this could be optimized later)

Let's go with it

Ref: https://github.com/tonsky/FiraCode

I just would import the font file or isn't that a good practice 🤔

softmarshmallow commented 3 years ago

I just wanted get feedback on my idea of using the fira code font for the code blocks (live demo can be found here)

Seems like very suiting font for code blocks. I'll Update the designs too.

(Actually i was looking for something like this.)

One concern might be the font loading performance - since ony in docs it uses almost 3 fontfaces. (this could be optimized later)

Let's go with it

Ref: https://github.com/tonsky/FiraCode

I just would import the font file or isn't that a good practice 🤔

I think it'll be just fine