Remove external source code

sveeke commented 5 years ago

We exclusively use local sources since external sources violate privacy by tracking users and add attack surface to the system and application. I only checked this file, but this issue applies to all external sources in all code.

Of course, if the code doesn't get used it's less of an issue. But then again: if it isn't used then it can be deleted.

In https://raw.githubusercontent.com/surfedushare/surf-frontend/develop/nuxt.config.js:

      {
        rel: 'stylesheet',
        href: 'https://fonts.googleapis.com/css?family=Source+Sans+Pro'
      },
      {
        rel: 'stylesheet',
        href: 'https://use.typekit.net/eya4qgt.css'
}

sveeke commented 5 years ago

What is the status of this issue?

YuriiDunaev commented 5 years ago

The google font is run locally now and the Typekit fonts should be discussed intern with SURF. https://github.com/surfedushare/surf-frontend/commit/087a5c17f429673117f92fa3fb302dbbd896950f

sveeke commented 5 years ago

Well that's a start. Can I assume from your reply that the font used by SURF is normally only available through Typekit and can't be run local?

surfedushare / surf-frontend

Remove external source code #12