search

surfrock66 / torque

A set of tools used with the Torque app for Android to store OBD2 data in MySQL, view GPS data from Torque on a map in real time using the Google Maps JavaScript API, plot OBD2 data in time series charts, and export the data to CSV or JSON.
Other
43 stars 24 forks source link

OpenStreetMap support #41

Closed mo5245 closed 3 years ago

mo5245 commented 3 years ago

Support to use OpenStreetMap with Map tiles by Stamen Design and LeafletJS, no API key required, set $use_OSM to true to change from default Google Maps

surfrock66 commented 3 years ago

I merged it because I think it's a great add, but what would you think of moving the setting to creds/creds-sample? I trust your code; I haven't used this in a while since I stopped driving to work due to covid and my ODBII adapter drained my battery and I unplugged it lol. I like OSM better, I pulled the google code from the original project. I like that it's switchable for user choice.

mo5245 commented 3 years ago

Yeah I was initially, unsure how necessary the map change is, Google Maps gives 100k requests, MapBox gives 50k and Thunderforest 150k request monthly with free tier. I like Stamen Design map tiles as no account setup is needed but is less detailed\annotated as others. I'll probably try the others at some point and move the config options over to creds at that time.

surfrock66 commented 3 years ago

Sounds good. I don't think the limit thing is a big issue; My personal server is the demo and I get a lot of hits and never got hit up for money, but I've been more of the "get ready to break up with google just in case" mindset which is why I liked the OSM idea.