search

surfrock66 / torque

A set of tools used with the Torque app for Android to store OBD2 data in MySQL, view GPS data from Torque on a map in real time using the Google Maps JavaScript API, plot OBD2 data in time series charts, and export the data to CSV or JSON.
Other
43 stars 24 forks source link

added options for Openlayers to select map provider from Esri or Stamen and the base layer is now Esri satellite image #50

Closed JauminaKape closed 2 years ago

JauminaKape commented 2 years ago

Just added a few things to the openlayers map provider, changed a php code used to filter something that could be done in sql and added decimals to the distance chart.

Would You accept bigger changes, like actually changing the sql sentences to use prepared statements and binding the parameters, or maybe separating the server side logic from the ui static files and rewriting the other map provider that aren't my contributions?

surfrock66 commented 2 years ago

Yea, big commits are totally fine, I'll probably wait to merge them until I can actually get them in my test environment, but the only thing that gives me pause is actually changing the DB schema as I never gave much thought to DB migrations. Ideally there would be a "db version" tag somewhere to check against, but I never got that far...for years this was "functionally complete" especially as I didn't drive during covid lol, but I've started driving again and your changes are great.