surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

add safe animator checking if number of generators are equal to numbe… #212

Closed NullIsOne closed 1 year ago

NullIsOne commented 1 year ago

Что сделано?

Зачем это сделано?

Чтобы в библиотеке было унифицированное решение исключающее ошибку в будущих плагинах.

На что обратить внимание?

Как протестировать?

github-actions[bot] commented 1 year ago
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against f2d772e0661e010b72e2d436069698fc21d1afbd

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 38.88% and project coverage change: -0.02 :warning:

Comparison is base (65451f2) 61.59% compared to head (f6f5c0f) 61.58%.

:exclamation: Current head f6f5c0f differs from pull request most recent head f2d772e. Consider uploading reports for the commit f2d772e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## SPT-0-Revision-expandable #212 +/- ## ============================================================= - Coverage 61.59% 61.58% -0.02% ============================================================= Files 127 129 +2 Lines 4788 4784 -4 Branches 2173 2172 -1 ============================================================= - Hits 2949 2946 -3 + Misses 1728 1723 -5 - Partials 111 115 +4 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `43.64% <38.88%> (+0.05%)` | :arrow_up: | | unittests | `38.85% <24.07%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [Source/Table/Animator/TableUpdatesAnimator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL0FuaW1hdG9yL1RhYmxlVXBkYXRlc0FuaW1hdG9yLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...llection/DataSource/BaseCollectionDataSource.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vRGF0YVNvdXJjZS9CYXNlQ29sbGVjdGlvbkRhdGFTb3VyY2Uuc3dpZnQ=) | `80.89% <33.33%> (+8.89%)` | :arrow_up: | | [Source/Table/DataSource/BaseTableDataSource.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL0RhdGFTb3VyY2UvQmFzZVRhYmxlRGF0YVNvdXJjZS5zd2lmdA==) | `81.42% <33.33%> (+11.05%)` | :arrow_up: | | [...e/Collection/Animator/CollectionSafeAnimator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vQW5pbWF0b3IvQ29sbGVjdGlvblNhZmVBbmltYXRvci5zd2lmdA==) | `40.00% <40.00%> (ø)` | | | [Source/Table/Animator/TableSafeAnimator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL0FuaW1hdG9yL1RhYmxlU2FmZUFuaW1hdG9yLnN3aWZ0) | `40.00% <40.00%> (ø)` | | | [...tion/Animator/CollectionBatchUpdatesAnimator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vQW5pbWF0b3IvQ29sbGVjdGlvbkJhdGNoVXBkYXRlc0FuaW1hdG9yLnN3aWZ0) | `66.66% <50.00%> (-33.34%)` | :arrow_down: | | [Source/Protocols/Animator/Animator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9BbmltYXRvci9BbmltYXRvci5zd2lmdA==) | `75.00% <50.00%> (ø)` | | | [...rce/Table/Animator/TableBatchUpdatesAnimator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL0FuaW1hdG9yL1RhYmxlQmF0Y2hVcGRhdGVzQW5pbWF0b3Iuc3dpZnQ=) | `66.66% <50.00%> (-33.34%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/212/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.