surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

SPT-1000 Создать разделитель #216

Closed Golubeykov closed 1 year ago

Golubeykov commented 1 year ago

SPT-1000

Что сделано?

Создал переиспользуемую ячейку-разделитель.

Зачем это сделано?

Сделать альтернативу системным сепараторам.

Как протестировать?

1) Установить патч (если нужно, могу создать отдельный раздел в табе Table, но пока решил сделать на примере Table with foldable cell) ReactiveDataDisplayManager-14-02-08.patch 2) Таб Table 3) Table with foldable cell 4) Убедиться в наличии сепараторов, можно поиграть с их размерами

Демо

github-actions[bot] commented 1 year ago
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 42450da3a875f23683a77fc2f6a48471b5ee84ed

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -29.96 :warning:

Comparison is base (2b7ab4c) 69.68% compared to head (42450da) 39.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #216 +/- ## ============================================ - Coverage 69.68% 39.73% -29.96% ============================================ Files 141 141 Lines 4153 4153 Branches 1876 1866 -10 ============================================ - Hits 2894 1650 -1244 - Misses 1161 2436 +1275 + Partials 98 67 -31 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `?` | | | unittests | `39.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. [see 79 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/216/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Golubeykov commented 1 year ago

@NullIsOne увидел лишнюю проперти, удалил.