surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

[SPT-1465] Аудит Example проекта. Поиск места отладки accessibility плагина. #224

Closed Ikeret closed 1 year ago

Ikeret commented 1 year ago

Что сделано?

Зачем это сделано?

На что обратить внимание?

github-actions[bot] commented 1 year ago
Warnings
:warning: The .yml file has been modified. Keep `changelog.md` up to date.
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 3bfe914b9790411c5171bf53e214076971fa33a1

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 3.61% and project coverage change: -25.94 :warning:

Comparison is base (f5ac38a) 63.21% compared to head (2357b9f) 37.27%.

:exclamation: Current head 2357b9f differs from pull request most recent head 64b79b5. Consider uploading reports for the commit 64b79b5 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/7.4 #224 +/- ## ================================================ - Coverage 63.21% 37.27% -25.94% ================================================ Files 135 141 +6 Lines 4959 5153 +194 Branches 2262 2367 +105 ================================================ - Hits 3135 1921 -1214 - Misses 1704 3151 +1447 + Partials 120 81 -39 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `?` | | | unittests | `37.27% <3.61%> (-1.32%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [...e/Collection/Delegate/BaseCollectionDelegate.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vRGVsZWdhdGUvQmFzZUNvbGxlY3Rpb25EZWxlZ2F0ZS5zd2lmdA==) | `47.55% <0.00%> (-37.07%)` | :arrow_down: | | [...ins/PluginAction/CollectionPaginatablePlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUGx1Z2lucy9QbHVnaW5BY3Rpb24vQ29sbGVjdGlvblBhZ2luYXRhYmxlUGx1Z2luLnN3aWZ0) | `24.28% <0.00%> (-62.86%)` | :arrow_down: | | [.../Collection/Protocols/CollectionFoldableItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUHJvdG9jb2xzL0NvbGxlY3Rpb25Gb2xkYWJsZUl0ZW0uc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...Accessibility/AccessibilityItem+Invalidation.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5SXRlbStJbnZhbGlkYXRpb24uc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...rs/Accessibility/AccessibilityItem+Providers.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5SXRlbStQcm92aWRlcnMuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...s/Accessibility/AccessibilityItem+Strategies.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5SXRlbStTdHJhdGVnaWVzLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...s/Generators/Accessibility/AccessibilityItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5SXRlbS5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [...nerators/Accessibility/AccessibilityModifier.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TW9kaWZpZXIuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...ce/Protocols/Plugins/Generators/FoldableItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvRm9sZGFibGVJdGVtLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [.../Protocols/Plugins/Generators/SelectableItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvU2VsZWN0YWJsZUl0ZW0uc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | ... and [11 more](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | | ... and [57 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/224/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Ikeret commented 1 year ago

Не вижу в чем ошибка при билде🤷🏻‍♂️ локально собирается и все тесты зеленые

NullIsOne commented 1 year ago

Не вижу в чем ошибка при билде🤷🏻‍♂️ локально собирается и все тесты зеленые

Снимок экрана 2023-06-01 в 12 56 56

Запусти юнит-тесты, выбрав framework таргет. Ошибки подсветятся

NullIsOne commented 1 year ago

Добавил комиты для починки тестов.

Основная причина как всегда: скрытые трейты и поведение на их основе.

  1. Переопределение трейтов отключено в UI тестах
  2. Тесты полагающиеся на a11y value + invalidate переписаны на прямой доступ к установке a11y value

По второму моменту возможно поможет прокачка инвалидатора, чтобы можно было инвалидировать только value или только label.

Плюс надо пройтись по замечаниям от линтера.