search

surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

Feature/spt 1468/footers for table #225

Closed NullIsOne closed 1 year ago

NullIsOne commented 1 year ago

Что сделано?

Зачем это сделано?

Чтобы возможности настройки таблицы и коллекции не отличались

На что обратить внимание?

Как протестировать?

github-actions[bot] commented 1 year ago
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 19723129037e8ed87e8aad1724fda4aebe31d2cf

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 59.64% and project coverage change: +0.36 :tada:

Comparison is base (f5ac38a) 63.21% compared to head (241f8ef) 63.58%.

:exclamation: Current head 241f8ef differs from pull request most recent head 1972312. Consider uploading reports for the commit 1972312 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/7.4 #225 +/- ## =============================================== + Coverage 63.21% 63.58% +0.36% =============================================== Files 135 140 +5 Lines 4959 5100 +141 Branches 2262 2337 +75 =============================================== + Hits 3135 3243 +108 - Misses 1704 1732 +28 - Partials 120 125 +5 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `46.61% <57.24%> (+1.01%)` | :arrow_up: | | unittests | `37.92% <17.50%> (-0.68%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [.../Collection/Protocols/CollectionFoldableItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUHJvdG9jb2xzL0NvbGxlY3Rpb25Gb2xkYWJsZUl0ZW0uc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...ce/Protocols/Plugins/Generators/FoldableItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvRm9sZGFibGVJdGVtLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...Table/Generators/EmptyGravityFooterGenerator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL0dlbmVyYXRvcnMvRW1wdHlHcmF2aXR5Rm9vdGVyR2VuZXJhdG9yLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [Source/Table/Manager/GravityTableManager.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL01hbmFnZXIvR3Jhdml0eVRhYmxlTWFuYWdlci5zd2lmdA==) | `73.05% <ø> (-0.42%)` | :arrow_down: | | [Source/Protocols/Protocols.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9Qcm90b2NvbHMuc3dpZnQ=) | `42.59% <21.42%> (-3.16%)` | :arrow_down: | | [...on/Generators/EmptyCollectionFooterGenarator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vR2VuZXJhdG9ycy9FbXB0eUNvbGxlY3Rpb25Gb290ZXJHZW5hcmF0b3Iuc3dpZnQ=) | `22.72% <25.00%> (+0.50%)` | :arrow_up: | | [...rce/Collection/Manager/BaseCollectionManager.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vTWFuYWdlci9CYXNlQ29sbGVjdGlvbk1hbmFnZXIuc3dpZnQ=) | `75.72% <33.33%> (-0.75%)` | :arrow_down: | | [Source/Table/Manager/BaseTableManager.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL01hbmFnZXIvQmFzZVRhYmxlTWFuYWdlci5zd2lmdA==) | `65.59% <40.57%> (-14.76%)` | :arrow_down: | | [...lugins/PluginAction/TableAccessibilityPlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL1BsdWdpbnMvUGx1Z2luQWN0aW9uL1RhYmxlQWNjZXNzaWJpbGl0eVBsdWdpbi5zd2lmdA==) | `43.33% <43.33%> (ø)` | | | [...lugins/PluginAction/TableHeaderVisiblePlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL1BsdWdpbnMvUGx1Z2luQWN0aW9uL1RhYmxlSGVhZGVyVmlzaWJsZVBsdWdpbi5zd2lmdA==) | `66.66% <50.00%> (ø)` | | | ... and [18 more](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/225/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.