surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

[SPT-1475] Readme для a11y плагина #228

Closed Ikeret closed 1 year ago

Ikeret commented 1 year ago

Что сделано?

Зачем это сделано?

Как протестировать

На что обратить внимание

github-actions[bot] commented 1 year ago
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 3aaaf5e1dbd9fe02e1ff5a94021bb69649c7eb20

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -25.91 :warning:

Comparison is base (3bfe914) 62.45% compared to head (3aaaf5e) 36.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/7.4 #228 +/- ## ================================================ - Coverage 62.45% 36.55% -25.91% ================================================ Files 143 143 Lines 5293 5296 +3 Branches 2446 2437 -9 ================================================ - Hits 3306 1936 -1370 - Misses 1862 3279 +1417 + Partials 125 81 -44 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `?` | | | unittests | `36.55% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [...Accessibility/AccessibilityItem+Invalidation.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5SXRlbStJbnZhbGlkYXRpb24uc3dpZnQ=) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...s/Accessibility/AccessibilityItem+Strategies.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5SXRlbStTdHJhdGVnaWVzLnN3aWZ0) | `0.00% <ø> (-29.42%)` | :arrow_down: | ... and [72 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

NullIsOne commented 1 year ago

Хорошая структура доки. Одобряю

Ikeret commented 1 year ago

В Usage кажется что надо больше картинок с устройства надо добавить)