Feature/spt 1486/automatic audit setup

NullIsOne commented 1 year ago

Что сделано?

Добавлен performAccessibilityAudit в UI тесты
Исправлены все замечания аудитора
...

Зачем это сделано?

Для улучшения качества Example-проекта.

На что обратить внимание?

Требует Xcode 15
Скорее всего CI упадет так как на runner еще не завезли Xcode 15
Resize сделан минимальными усилиями. Для Grid качественней было бы менять itemSize в layout на основе текущей traitCollection.
Добавление CalculatableHeightItem и SizableItem довольно монотонная задача. Стоит подумать о способе декорирования базового генератора возможностью вычислять референсный размер.
...

Как протестировать?

Запустить тесты из ReactiveDataDisplayManagerExampleUITests

github-actions[bot] commented 1 year ago

	Messages
:book:	Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against d5a7be2227e1aa641374d28330d461ed8e935209

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.76 :warning:

Comparison is base (3bfe914) 62.45% compared to head (d5a7be2) 60.70%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release/7.4 #229 +/- ## =============================================== - Coverage 62.45% 60.70% -1.76% =============================================== Files 143 143 Lines 5293 5296 +3 Branches 2446 2447 +1 =============================================== - Hits 3306 3215 -91 - Misses 1862 1955 +93 - Partials 125 126 +1 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `44.11% <100.00%> (-2.34%)` | :arrow_down: | | unittests | `36.55% <0.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [Source/Collection/CollectionCell+RDDM.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vQ29sbGVjdGlvbkNlbGwrUkRETS5zd2lmdA==) | `100.00% <100.00%> (ø)` | | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/229/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Ikeret commented 1 year ago

В iOS 16 добавляли selfSizingInvalidation - механизм когда ячейка может сама обновить свои размеры, можно подумать как это добавить к нам

https://developer.apple.com/documentation/uikit/uicollectionview/4001100-selfsizinginvalidation https://developer.apple.com/documentation/uikit/uitableview/4001105-selfsizinginvalidation

https://developer.apple.com/videos/play/wwdc2022/10068/

NullIsOne commented 1 year ago

https://developer.apple.com/documentation/uikit/uitableview/4001105-selfsizinginvalidation

Вынес в отдельную задачку

surfstudio / ReactiveDataDisplayManager