surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

[SPT-1572] intro in macro #231

Open NullIsOne opened 1 year ago

NullIsOne commented 1 year ago

Что сделано?

Зачем это сделано?

Для освоения макросов и скрытия однотипного кода в компонентах.

На что обратить внимание?

Как протестировать?

github-actions[bot] commented 1 year ago
Warnings
:warning: The .yml file has been modified. Keep `changelog.md` up to date.
:warning: Oops! We have found some issues. It's better to fix them to keep code clean

SwiftLint found issues

Severity File Reason
Warning Decl+Extensions.swift:37 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Decl+Extensions.swift:22 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
Warning BuildableMacro.swift:75 Force unwrapping should be avoided. (force_unwrapping)
Error BuildableMacro.swift:16 Line should be 145 characters or less: currently 277 characters (line_length)
Error BuildableMacro.swift:20 Line should be 145 characters or less: currently 231 characters (line_length)
Warning BuildableMacro.swift:51 Lines should not have trailing whitespace. (trailing_whitespace)
Error MutableMacro.swift:8 Line should be 145 characters or less: currently 231 characters (line_length)
Warning MutableMacro.swift:41 Lines should not have trailing whitespace. (trailing_whitespace)
Warning MessageView.swift:253 Line should be 145 characters or less: currently 151 characters (line_length)
Warning MessageView.swift:123 Lines should not have trailing whitespace. (trailing_whitespace)

Generated by :no_entry_sign: Danger Swift against 1a5c5ad97810baf18b594b84b6125782cf9e9c7d

NullIsOne commented 1 year ago

Обновил MutableMacroTests Теперь все кейсы теста корректно отрабатывают

NullIsOne commented 1 year ago

Перевожу CI на Xcode 15 раз уж в Gihub Actions добавили его, а тут

{ platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 17.0 is not installed. To use with Xcode, first download and install the platform }

Не до конца установили (Не поставили симулятор)