surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

SPT-488 RDDM. GitHub Actions #232

Closed Ikeret closed 1 year ago

Ikeret commented 1 year ago

Что сделано?

github-actions[bot] commented 1 year ago
Warnings
:warning: The .yml file has been modified. Keep `changelog.md` up to date.
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 9b837203db8e843d6fc045ed02d4473586cecd1d

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +1.66 :tada:

Comparison is base (a2d5f1d) 69.68% compared to head (9b83720) 71.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #232 +/- ## =========================================== + Coverage 69.68% 71.34% +1.66% =========================================== Files 141 141 Lines 4153 4153 Branches 1876 1875 -1 =========================================== + Hits 2894 2963 +69 + Misses 1161 1083 -78 - Partials 98 107 +9 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `58.84% <ø> (+1.66%)` | :arrow_up: | | unittests | `39.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. [see 6 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/232/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Ikeret commented 1 year ago

todo: фейлить степ, если код не 200

image
Ikeret commented 1 year ago

todo: фейлить степ, если код не 200

при редактировании ПР:

Можно было бы отказаться от экшена edited. Редактировать тайтл после фейла и перезапускать, но re-run запускает его с предыдущим тайтлом, в данном случае поможет только reopen.

@NullIsOne как лучше сделать? Можно к примеру брать ключи задач из ветки и заголовка и убрать экшен на редактирование ПР

Ikeret commented 1 year ago