surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

Hotfix/replace hardcoded animation parameter #234

Closed NullIsOne closed 1 year ago

NullIsOne commented 1 year ago

Что сделано?

Зачем это сделано?

Чтобы флаг пробрасывался из ExpandableItemб. как и задумывалось.

На что обратить внимание?

github-actions[bot] commented 1 year ago
Warnings
:warning: The .yml file has been modified. Keep `changelog.md` up to date.
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 9e2b85d2ec490e2fecdaaa358f9352a648072858

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/7.3.6@8f1103b). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head e872bbe differs from pull request most recent head 9e2b85d. Consider uploading reports for the commit 9e2b85d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/7.3.6 #234 +/- ## ================================================ Coverage ? 45.93% ================================================ Files ? 132 Lines ? 4872 Branches ? 2199 ================================================ Hits ? 2238 Misses ? 2552 Partials ? 82 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `45.93% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

NullIsOne commented 1 year ago

поправил замечание и починил отключение анимации

https://github.com/surfstudio/ReactiveDataDisplayManager/assets/28707156/bf6103b4-def8-4475-9a78-54a5a5730420

причина неработающей анимации была в реализации SafeAnimator и проверках

еще подумаю как это и главный фикс 7.3.5 совместить

NullIsOne commented 1 year ago

Теперь точно поправил)

В 7.3.5 мы добавили связку аниматоров и не учли что при animated = false Animator1.perform -> UIView.perfromWithoutAnimation + Animator1.performAnimated -> Animator2.performAnimated -> Animator3.performAnimated то есть второй и последний аниматор в цепочке будет вызван вне UIView.performWithoutAnimation

Поэтому анимация в примере ExpandableCell оставалась вне зависимости от состояния свитча.

Теперь работает так при animated = false Animator1.perform -> Animator2.perform -> Animator3.perform -> UIView.performWithoutAnimation + Animator3.performAnimated @kombatkos @Ikeret готово к ревью