search

surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

[SPT-1364] [Коллекция] Плагин TwoDirectionalPaginatable #241

Closed Golubeykov closed 1 year ago

Golubeykov commented 1 year ago

SPT-1364

Что сделано?

Зачем это сделано?

Добавить новые возможности для библиотеки. Как пример, обратная пагинация может использоваться в чатах.

На что обратить внимание

При обратной пагинации (если скроллить наверх), при после вставки новых ячеек в начало, сбивается позиция изнального скролла примерно на 20 единиц. В таблице получилось пофиксить это сменив стиль с Grouped на Plain. В коллекции такого нет. Поэтому поищу целевое решение в рамках https://jira.surfstudio.ru/browse/SPT-1514 . При чем эта проблема актуальна только для второй страницы скролла. Дальнейшие страницы грузятся с корректным возвратом на изначальную позицию скролла.

Как протестировать?

Чтобы воспроизвести проблему надо: Зайти в Collection -> Collection with two direction pagination -> Проскроллить вверх.

Демо https://github.com/surfstudio/ReactiveDataDisplayManager/assets/47087482/017ba0b4-7532-43c8-8eac-b01140b1f5bf
github-actions[bot] commented 1 year ago
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 017092891551cc62a9ece4ac4edd458e84f99594

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 4.34% and project coverage change: -0.95 :warning:

Comparison is base (5084a8c) 69.82% compared to head (1563f22) 68.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/SPT-1363/two-directional-paginatable #241 +/- ## ================================================================================ - Coverage 69.82% 68.88% -0.95% ================================================================================ Files 142 143 +1 Lines 4209 4274 +65 Branches 1896 1924 +28 ================================================================================ + Hits 2939 2944 +5 - Misses 1173 1232 +59 - Partials 97 98 +1 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `57.15% <4.34%> (-0.77%)` | :arrow_down: | | unittests | `38.60% <4.34%> (-0.62%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [...inAction/CollectionBackwardPaginatablePlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUGx1Z2lucy9QbHVnaW5BY3Rpb24vQ29sbGVjdGlvbkJhY2t3YXJkUGFnaW5hdGFibGVQbHVnaW4uc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...ins/PluginAction/CollectionPaginatablePlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUGx1Z2lucy9QbHVnaW5BY3Rpb24vQ29sbGVjdGlvblBhZ2luYXRhYmxlUGx1Z2luLnN3aWZ0) | `82.43% <0.00%> (-4.72%)` | :arrow_down: | | [...rce/Collection/Manager/BaseCollectionManager.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vTWFuYWdlci9CYXNlQ29sbGVjdGlvbk1hbmFnZXIuc3dpZnQ=) | `75.96% <75.00%> (-0.78%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/241/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.