surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

Hotfix/spt 1546/insert func optimisation #246

Closed NullIsOne closed 1 year ago

NullIsOne commented 1 year ago

Что сделано?

Зачем это сделано?

По заявке с проекта, на котором было замечено падение.

На что обратить внимание?

Как протестировать?

github-actions[bot] commented 1 year ago
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 4944fec7700d7a55064378a9b9d445369b6b86fe

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 47.61% and project coverage change: -0.03 :warning:

Comparison is base (a42fc5c) 61.40% compared to head (e59bd81) 61.37%.

:exclamation: Current head e59bd81 differs from pull request most recent head 15156bd. Consider uploading reports for the commit 15156bd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/7.3.7 #246 +/- ## ================================================= - Coverage 61.40% 61.37% -0.03% ================================================= Files 135 133 -2 Lines 5052 4987 -65 Branches 2282 2244 -38 ================================================= - Hits 3102 3061 -41 + Misses 1837 1812 -25 - Partials 113 114 +1 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `44.33% <21.69%> (+0.48%)` | :arrow_up: | | unittests | `38.39% <42.32%> (+0.23%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [...Collection/Modifier/CollectionCommonModifier.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vTW9kaWZpZXIvQ29sbGVjdGlvbkNvbW1vbk1vZGlmaWVyLnN3aWZ0) | `36.50% <0.00%> (-6.09%)` | :arrow_down: | | [...llection/Modifier/CollectionDiffableModifier.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vTW9kaWZpZXIvQ29sbGVjdGlvbkRpZmZhYmxlTW9kaWZpZXIuc3dpZnQ=) | `51.47% <0.00%> (-2.38%)` | :arrow_down: | | [Source/Protocols/Modifier/Modifier.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9Nb2RpZmllci9Nb2RpZmllci5zd2lmdA==) | `10.00% <0.00%> (-1.12%)` | :arrow_down: | | [Source/Table/Modifier/TableDiffableModifier.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL01vZGlmaWVyL1RhYmxlRGlmZmFibGVNb2RpZmllci5zd2lmdA==) | `51.47% <0.00%> (-2.38%)` | :arrow_down: | | [Source/Table/Manager/ManualTableManager.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL01hbmFnZXIvTWFudWFsVGFibGVNYW5hZ2VyLnN3aWZ0) | `68.80% <45.26%> (+13.25%)` | :arrow_up: | | [Source/Table/Modifier/TableRowAnimation.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL01vZGlmaWVyL1RhYmxlUm93QW5pbWF0aW9uLnN3aWZ0) | `50.00% <50.00%> (ø)` | | | [Source/Table/Manager/GravityTableManager.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL01hbmFnZXIvR3Jhdml0eVRhYmxlTWFuYWdlci5zd2lmdA==) | `65.31% <51.72%> (ø)` | | | [...rce/Collection/Manager/BaseCollectionManager.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vTWFuYWdlci9CYXNlQ29sbGVjdGlvbk1hbmFnZXIuc3dpZnQ=) | `75.58% <66.66%> (-0.89%)` | :arrow_down: | | [...ble/Plugins/PluginAction/TableFoldablePlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL1BsdWdpbnMvUGx1Z2luQWN0aW9uL1RhYmxlRm9sZGFibGVQbHVnaW4uc3dpZnQ=) | `79.54% <66.66%> (ø)` | | | [Source/Table/Modifier/TableCommonModifier.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL01vZGlmaWVyL1RhYmxlQ29tbW9uTW9kaWZpZXIuc3dpZnQ=) | `62.50% <70.00%> (+1.38%)` | :arrow_up: | | ... and [1 more](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/246/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.