search

surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

SPT-1477 Добавление SizableItem компонентам #248

Closed kombatkos closed 1 year ago

kombatkos commented 1 year ago

Что сделано?

Зачем это сделано?

На что обратить внимание?

Как протестировать?

github-actions[bot] commented 1 year ago
Warnings
:warning: Oops! We have found some issues. It's better to fix them to keep code clean

SwiftLint found issues

Severity File Reason
Warning MessageView.swift:137 Redundant explicit declaration of default types should be avoided (redundant_default_type)
Warning MessageView.swift:295 Line should be 145 characters or less: currently 151 characters (line_length)
Warning MessageView.swift:115 Lines should not have trailing whitespace. (trailing_whitespace)

Generated by :no_entry_sign: Danger Swift against 2582cf95ef6484c2472c41b604beeb5e34620666

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.32 :warning:

Comparison is base (91ac95d) 71.37% compared to head (2582cf9) 71.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #248 +/- ## =========================================== - Coverage 71.37% 71.05% -0.32% =========================================== Files 146 146 Lines 4457 4457 Branches 2000 2000 =========================================== - Hits 3181 3167 -14 - Misses 1176 1188 +12 - Partials 100 102 +2 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `61.00% <ø> (-0.32%)` | :arrow_down: | | unittests | `37.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. [see 3 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/248/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

NullIsOne commented 1 year ago

251 готов

Расчеты ширины для separator и spacer добавлены