search

surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

SPT-1521 RDDM. Унифицировать BaseEvent #249

Closed kombatkos closed 1 year ago

kombatkos commented 1 year ago

Что сделано?

Зачем это сделано?

На что обратить внимание?

Как протестировать?

github-actions[bot] commented 1 year ago
Messages
:book: Great! We didn't found any violations in your changes. Congratulations 🎉

Generated by :no_entry_sign: Danger Swift against 8df4cf8db42539b2e99cb572e7bc23fcae345a8e

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 92.45% and project coverage change: +1.92 :tada:

Comparison is base (5d900fd) 71.06% compared to head (8df4cf8) 72.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #249 +/- ## =========================================== + Coverage 71.06% 72.98% +1.92% =========================================== Files 146 146 Lines 4472 4457 -15 Branches 2007 2000 -7 =========================================== + Hits 3178 3253 +75 + Misses 1194 1095 -99 - Partials 100 109 +9 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `62.93% <61.53%> (+1.89%)` | :arrow_up: | | unittests | `37.24% <64.15%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [...on/Plugins/PluginAction/BaseCollectionPlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUGx1Z2lucy9QbHVnaW5BY3Rpb24vQmFzZUNvbGxlY3Rpb25QbHVnaW4uc3dpZnQ=) | `70.00% <0.00%> (ø)` | | | [...ce/Protocols/Plugins/Generators/FoldableItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvRm9sZGFibGVJdGVtLnN3aWZ0) | `0.00% <ø> (ø)` | | | [Source/Protocols/Plugins/PluginAction/Plugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL1BsdWdpbkFjdGlvbi9QbHVnaW4uc3dpZnQ=) | `100.00% <ø> (ø)` | | | [...s/CalculatableHeightNonReusableCellGenerator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL0dlbmVyYXRvcnMvQ2FsY3VsYXRhYmxlSGVpZ2h0Tm9uUmV1c2FibGVDZWxsR2VuZXJhdG9yLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...e/Table/Plugins/PluginAction/BaseTablePlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL1BsdWdpbnMvUGx1Z2luQWN0aW9uL0Jhc2VUYWJsZVBsdWdpbi5zd2lmdA==) | `70.00% <0.00%> (ø)` | | | [...ction/Generators/BaseCollectionCellGenerator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vR2VuZXJhdG9ycy9CYXNlQ29sbGVjdGlvbkNlbGxHZW5lcmF0b3Iuc3dpZnQ=) | `92.59% <100.00%> (ø)` | | | [...n/Generators/FoldableCollectionCellGenerator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vR2VuZXJhdG9ycy9Gb2xkYWJsZUNvbGxlY3Rpb25DZWxsR2VuZXJhdG9yLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [...s/PluginAction/CollectionPrefetchProxyPlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUGx1Z2lucy9QbHVnaW5BY3Rpb24vQ29sbGVjdGlvblByZWZldGNoUHJveHlQbHVnaW4uc3dpZnQ=) | `100.00% <100.00%> (ø)` | | | [...tion/CollectionScrollViewDelegateProxyPlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUGx1Z2lucy9QbHVnaW5BY3Rpb24vQ29sbGVjdGlvblNjcm9sbFZpZXdEZWxlZ2F0ZVByb3h5UGx1Z2luLnN3aWZ0) | `92.42% <100.00%> (ø)` | | | [...gins/PluginAction/CollectionSelectablePlugin.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUGx1Z2lucy9QbHVnaW5BY3Rpb24vQ29sbGVjdGlvblNlbGVjdGFibGVQbHVnaW4uc3dpZnQ=) | `82.60% <100.00%> (ø)` | | | ... and [9 more](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/249/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.