surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

SPT-1554 Сделать SpacerView горизонтальным #251

Closed kombatkos closed 1 year ago

kombatkos commented 1 year ago

Что сделано?

Зачем это сделано?

Для построения сложных генераторов в стеке

На что обратить внимание?

Как протестировать?

Снимок экрана 2023-07-18 в 15 40 14

github-actions[bot] commented 1 year ago
Warnings
:warning: Oops! We have found some issues. It's better to fix them to keep code clean

SwiftLint found issues

Severity File Reason
Warning ComponentsOverviewTableViewController.swift:109 Line should be 145 characters or less: currently 148 characters (line_length)

Generated by :no_entry_sign: Danger Swift against 91ac95d1e07d683a91f876f56d3542413d0b9b0b

NullIsOne commented 1 year ago

Так как ПР блокирует соседний #248, предлагаю поправить лишь замечание по Axis - ViewSize

Добавление динамического размера также нужно для UIEdgeInsets а не только для Space/ Separator. Это замечание будет вынесено в отдельную задачу и снабжено более четкими требованиями к реализации и отладке.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -34.13 :warning:

Comparison is base (ed8a7ae) 71.37% compared to head (91ac95d) 37.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #251 +/- ## ============================================ - Coverage 71.37% 37.24% -34.13% ============================================ Files 146 146 Lines 4457 4457 Branches 2000 1990 -10 ============================================ - Hits 3181 1660 -1521 - Misses 1176 2731 +1555 + Partials 100 66 -34 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `?` | | | unittests | `37.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. [see 85 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/251/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.