surfstudio / ReactiveDataDisplayManager

MIT License
34 stars 13 forks source link

Merge 7.4 and resolve conflicts #254

Closed NullIsOne closed 1 year ago

NullIsOne commented 1 year ago

Что сделано?

Зачем это сделано?

Чтобы объединить изменения из готовящейся 8.0 и зарелиженой. 7.4

На что обратить внимание?

Как протестировать?

github-actions[bot] commented 1 year ago
Warnings
:warning: The .yml file has been modified. Keep `changelog.md` up to date.
:warning: Oops! We have found some issues. It's better to fix them to keep code clean

SwiftLint found issues

Severity File Reason
Warning AccessibilityItem+Invalidation.swift:90 Line should be 145 characters or less: currently 158 characters (line_length)

Generated by :no_entry_sign: Danger Swift against 7fd0ec7ef1d52ae40e681cb071ab03eed68fc018

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 60.34% and project coverage change: +1.28% :tada:

Comparison is base (aa95890) 71.37% compared to head (7fd0ec7) 72.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #254 +/- ## =========================================== + Coverage 71.37% 72.66% +1.28% =========================================== Files 146 161 +15 Lines 4457 4905 +448 Branches 2000 2224 +224 =========================================== + Hits 3181 3564 +383 - Misses 1176 1221 +45 - Partials 100 120 +20 ``` | Flag | Coverage Δ | | |---|---|---| | uitests | `64.05% <61.04%> (+2.73%)` | :arrow_up: | | unittests | `34.02% <7.54%> (-3.22%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [...on/Generators/EmptyCollectionFooterGenarator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vR2VuZXJhdG9ycy9FbXB0eUNvbGxlY3Rpb25Gb290ZXJHZW5hcmF0b3Iuc3dpZnQ=) | `66.66% <0.00%> (ø)` | | | [.../Collection/Protocols/CollectionFoldableItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL0NvbGxlY3Rpb24vUHJvdG9jb2xzL0NvbGxlY3Rpb25Gb2xkYWJsZUl0ZW0uc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...cessibility/Container/AccessibilityContainer.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9Db250YWluZXIvQWNjZXNzaWJpbGl0eUNvbnRhaW5lci5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [...ssibility/Container/AccessibilityItemWrapper.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9Db250YWluZXIvQWNjZXNzaWJpbGl0eUl0ZW1XcmFwcGVyLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...ators/Accessibility/Item/AccessibilityAction.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9JdGVtL0FjY2Vzc2liaWxpdHlBY3Rpb24uc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...lity/Modifier/AccessibilityContainerModifier.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvQWNjZXNzaWJpbGl0eS9Nb2RpZmllci9BY2Nlc3NpYmlsaXR5Q29udGFpbmVyTW9kaWZpZXIuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...ce/Protocols/Plugins/Generators/FoldableItem.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1Byb3RvY29scy9QbHVnaW5zL0dlbmVyYXRvcnMvRm9sZGFibGVJdGVtLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...Table/Generators/EmptyGravityFooterGenerator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL0dlbmVyYXRvcnMvRW1wdHlHcmF2aXR5Rm9vdGVyR2VuZXJhdG9yLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...e/Table/Generators/EmptyTableFooterGenerator.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL0dlbmVyYXRvcnMvRW1wdHlUYWJsZUZvb3RlckdlbmVyYXRvci5zd2lmdA==) | `72.72% <0.00%> (+72.72%)` | :arrow_up: | | [Source/Table/Manager/GravityTableManager.swift](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-U291cmNlL1RhYmxlL01hbmFnZXIvR3Jhdml0eVRhYmxlTWFuYWdlci5zd2lmdA==) | `74.11% <0.00%> (+1.28%)` | :arrow_up: | | ... and [29 more](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/surfstudio/ReactiveDataDisplayManager/pull/254/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

NullIsOne commented 1 year ago

Итого возьмем на заметку что мердж прошел успешно за исключением a11y теста стеков и компонентов. Снимок экрана 2023-07-25 в 13 49 49

На CI успех потому что пока проверяем на Xcode 14.

Разработка и отладка стековой ячейки в процессе - #253 Пример с компонентами будет упразднен и полностью переедет в чат.