surfstudio / flutter-bottom-sheet

Custom bottom sheet widget, that can resize by drag and then scroll. Made by Surf 🏄
Apache License 2.0
164 stars 42 forks source link

fix(): snackbar issue fix #76

Closed GalimzyanovDanil closed 1 year ago

GalimzyanovDanil commented 1 year ago

Checklist

Changes

How does this PR fix the problem?

Since the snackbar is shown relative to the current active scaffold, it was necessary to remove the scaffold from the widget tree, leaving the possibility of displaying the snackbar on top of the bottom sheet. A new parameter was added that allows you to remove the scaffold from the bootom sheet widget tree.

With Scaffold in widget tree.

https://user-images.githubusercontent.com/86564275/216302668-8ac7c46a-517c-498d-ae1a-8a7c1d101e88.mov

Without Scaffold in widget tree.

https://user-images.githubusercontent.com/86564275/216302705-5adec5d6-eefe-4733-9b32-22a140ecb8b5.mov

dshevchenkoo commented 1 year ago

@GalimzyanovDanil exception on analysis check flutter version for package, maybe need to update?

GalimzyanovDanil commented 1 year ago

@GalimzyanovDanil exception on analysis check flutter version for package, maybe need to update?

I can fix depracted fields, but this dont resolve all problems. Also needed upgrade surf_lint_rules package.

internetova commented 1 year ago

2023-07-31 17 51 22

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1c528c9) 100.00% compared to head (3281937) 100.00%.

:exclamation: Current head 3281937 differs from pull request most recent head 8f5833a. Consider uploading reports for the commit 8f5833a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #76 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 4 4 Lines 254 267 +13 ========================================= + Hits 254 267 +13 ``` | [Files Changed](https://app.codecov.io/gh/surfstudio/flutter-bottom-sheet/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio) | Coverage Δ | | |---|---|---| | [lib/src/flexible\_bottom\_sheet.dart](https://app.codecov.io/gh/surfstudio/flutter-bottom-sheet/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-bGliL3NyYy9mbGV4aWJsZV9ib3R0b21fc2hlZXQuZGFydA==) | `100.00% <100.00%> (ø)` | | | [lib/src/flexible\_bottom\_sheet\_route.dart](https://app.codecov.io/gh/surfstudio/flutter-bottom-sheet/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=surfstudio#diff-bGliL3NyYy9mbGV4aWJsZV9ib3R0b21fc2hlZXRfcm91dGUuZGFydA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.