Fixed #55 Upgraded Kotlin version - Githubissues

surfstudio / flutter-otp-autofill

Made by Surf 🏄

Apache License 2.0

75 stars 43 forks source link

Fixed #55 Upgraded Kotlin version #56

Closed AgnelSelvan closed 1 year ago

AgnelSelvan commented 1 year ago

Related tasks

Depends on Issue #55

Changes

Updated Kotlin version from ext.kotlin_version = '1.3.50' to ext.kotlin_version = '1.7.10'

Checklist for self-check

[x] Commits and PRs have been filed according to the rules on the project.
[ ] The author is marked as an assigne and assigned mandatory reviewers.
[x] Required labels marked
[x] Specified related tasks and/or related PRs.
[x] Specified Changes.
[ ] Attached videos/screenshots demonstrating the fix/feature.
[x] All unspecified fields in the PR description deleted.
[ ] New code covered by tests.

Checklist for reviewers

[ ] CI passed successfully (with a green check mark).
[ ] PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

[ ] The code is decomposed into necessary and sufficient components.
[ ] System design corresponds to the agreements on structure and architecture on the project.

Functionality:

[x] The code solves the problem.
[x] Any changes to the user interface are reasonable and look good.

Complexity:

[x] The code is clear, easy to read, functions are small, no more than 50 lines.
[x] The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

[ ] Updated or added tests for mandatory components.
[ ] The tests are correct, helpful, and well designed/developed.

Naming:

[x] The naming of variables, methods, classes and other components is understandable.

Comments:

[x] The comments are understandable and helpful.

Documentation:

[x] All labels are correct
[ ] Technical documentation updated (after approval, updates last reviewer).

AgnelSelvan commented 1 year ago

Hey @tinted-knight , AGP version updated to the latest version but Kotlin version I tried updating to 1.8.22 the issue I faced is to update the example project as well to the latest 1.8 Kotlin version. If the user is using some old version of Kotlin then the user will be forced to update the Kotlin version to 1.8 as in 1.7.21 it's not the case. So keeping the Kotlin version as 1.7.21, which is common Flutter's latest new project's Kotlin version of Android.