SNP-267 fix: Android build - Githubissues

surfstudio / flutter-push-notification

Made by Surf 🏄

Apache License 2.0

26 stars 5 forks source link

SNP-267 fix: Android build #28

Closed mark-kascheev closed 12 months ago

mark-kascheev commented 1 year ago

Changes

With mavenCentral the android could not find dependencies, changing to the outdated jcenter - helped Also restored the work of ``example

Checklist

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Is there an existing issue for this PR?
- link issue here
[ ] Have the files been linted and formatted?
[ ] Have the docs been updated to match the changes in the PR?
[x] Commits and PRs have been filed according to the rules on the project.
[x] The author is marked as an assigne and assigned mandatory reviewers.
[x] Attached videos/screenshots demonstrating the fix/feature.
[x] All unspecified fields in the PR description deleted.

Checklist for reviewers

[ ] CI passed successfully (with a green check mark).
[ ] PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

[ ] System design corresponds to the agreements on structure and architecture on the project.
[ ] The code is decomposed into necessary and sufficient components.

Functionality:

[ ] The code solves the problem.
[ ] Any changes to the user interface are reasonable and look good.

Complexity:

[ ] The code is clear, easy to read, functions are small, no more than 50 lines.
[ ] The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

[ ] Updated or added tests for mandatory components.
[ ] The tests are correct, helpful, and well designed/developed.

Naming:

[ ] The naming of variables, methods, classes and other components is understandable.

Comments:

[ ] The comments are understandable and helpful.

Documentation:

[ ] Technical documentation updated (after approval, updates last reviewer).

vasilich6107 commented 1 year ago

Наоборот везде рекомендуют перейти на mavenCentral https://onesignal.com/blog/android-migrate-jcenter-to-maven-central/

vasilich6107 commented 1 year ago

https://search.maven.org/artifact/ru.surfstudio.android/push

vasilich6107 commented 1 year ago

В мавене лежит только версия 5, а версии 4 нету В тикете ошибка Could not find ru.surfstudio.android:push:0.4.0.

vasilich6107 commented 1 year ago

Вы можете мигрировать на последние версии? https://github.com/surfstudio/flutter-push-notification/blob/8ec12cf9544b678bcd4214d52d2acdb69cffb6ec/android/build.gradle#L44

vasilich6107 commented 1 year ago

То же самое касается активити холдера

codecov-commenter commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (194bf79) 100.00% compared to head (173baff) 100.00%.

:exclamation: Current head 173baff differs from pull request most recent head fbbca11. Consider uploading reports for the commit fbbca11 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #28 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 156 156 ========================================= Hits 156 156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.