surge-synthesizer / conduit

The Surge Synth Team Conduit Plugin Suite
Other
14 stars 4 forks source link

Mod FX cleanup #44

Open Andreya-Autumn opened 1 year ago

Andreya-Autumn commented 1 year ago
  1. The flanger stands totally still in the "I" preset, no matter the rate control. That one should have the noise LFO shape, and I remember we fixed a difference between the phaser and flanger at one point that made it not work in the flanger. In Shortcircuit the noise shape does work in the flanger though, so the issue must be in the conduit implementation not the sst-effects port.
  2. Across all of I II III on both effects, rate >20 sounds not great. Let's cap it?
  3. If it feels reasonable for you to go an extra mile here, I think best UX for these would be to have a preset macro instead of rate. It would control rate within the min-20hz range, but also change some other params along to keep the effect in the sweetspot across the rate range. Happy to set up a Surge patch with all six of these in it and a macro to each one as a reference. How about it?
Andreya-Autumn commented 1 year ago

...actually, on 1 above. I just noticed that when you first switch to flanger, it does seem to move for a second. Then stops somewhere, after which the rate control just makes a subtle timbral difference. I sanity checked against audio in to Surge and the preset is pretty subtle but in Surge you can definitely hear the noise when you dime the rate. Can't in Conduit.

baconpaul commented 1 year ago

On 3, that's relatively easy to do sure. I just need to know the base value for each macro-ed value and the upper range.

So somethin glike

"Patch 1: param 3 goes 12..15, param 6 goes 0.02 to -0.4 as macro goes 0 1"

I'l get the other two before we d that though.