search

surge-synthesizer / shortcircuit-xt

Will be a sampler when its done!
GNU General Public License v3.0
244 stars 27 forks source link

message names and message objects are a mess #1141

Open baconpaul opened 3 weeks ago

baconpaul commented 3 weeks ago

the a2s and s2a ones are fine but

all the c2s and s2c messages and associated objects have incoherent names.

easy to fix/refactor in clion so do it one day, with a rubric for how to create names, which you add as a comment.

baconpaul commented 3 weeks ago

Probably do at same time as #1111

baconpaul commented 2 weeks ago

While in there clean up associated sample set name

Screenshot 2024-08-30 at 9 49 22 AM

Red box is Sample which itself contains channel, bitrate, bitdepth, etc and sample data. Green box is the variant playback information currently called AssociatedSample. It hasa Sample Blue box is the set of variantes in the zone, currently called AssociatedSampleSet. It hasa vector of AssociatedSamples

AssociatedSampleSet is a terrible name since its not a set. AssociatedSample is an OK name but VariantData would be better. Image So probably "SingleVariantData" and "Variants" would be the right names