search

surge-synthesizer / shortcircuit-xt

Will be a sampler when its done!
GNU General Public License v3.0
246 stars 27 forks source link

True Random doesn't work with 2 samples #1286

Closed Andreya-Autumn closed 1 week ago

Andreya-Autumn commented 1 week ago

Why?

mkruselj commented 1 week ago

That one should just resort to cycling in this case.

Andreya-Autumn commented 1 week ago

That's what it does currently, but no it should not! The other random option never picks the same twice in a row. For that one your answer is correct. But we have a true random too remember? That one should be truly random, I'd think. :)

Andreya-Autumn commented 1 week ago

Oh I see why. Easy change. Will fix.

mkruselj commented 1 week ago

Ah right yeah true random, I misconnected things in my brain. It would help me if we kept using the terms "random" (rmeaning: random) and "shuffle" (meaning: non-repeating random). If this is not in code, would help if it were, too.

Andreya-Autumn commented 1 week ago

Shuffle and non-repeating random are not quite the same thing though. Say we have 10 samples loaded, a shuffle will never play 1 2 1 2 1 2 1 but no-repeat random might. What we have right now is indeed a shuffle so sure we can rename it I guess!

Relatedly, I've been thinking about exploring the difference between those two and perhaps adding the other if deemed interesting. But lemme make separate issues for these thoughts.