surge-synthesizer / shortcircuit-xt

Will be a sampler when its done!
GNU General Public License v3.0
259 stars 32 forks source link

Shape sample like Geonkick #613

Open sdfsfsfwrt opened 1 year ago

sdfsfsfwrt commented 1 year ago

Hi Geonkick have effective way to shape sample that i hopeful see it on shortcircuit-xt ScHBd.gif

mkruselj commented 1 year ago

This is not planned, sorry to say. At the very least not for the initial release.

baconpaul commented 1 year ago

I’m trying to figure out what that’s doing

is it just adjusting the playback rate with a curve? Shortcircuit can do thst today using the step sequencer to modulate the playback ratio. And if in the future we add the surge mseg etc…

mkruselj commented 1 year ago

It's basically using waveform area as envelope editor, separately for amplitude and pitch, and updates waveform display accordingly. Makes sense in a simple kickdrum synthesizer. Things get quite a lot more complicated in SC tho, I'd say.

baconpaul commented 1 year ago

Right but we can modulate pitch and amplitude with an envelope now. So while the ui is different you could do the requested feature right?

mkruselj commented 1 year ago

The feature doesn't make sense if the actual envelope editor is not overlaid over the sample. Location matters in this case. If it were to modify the waveform based on pitch envelope, this would make the UI confusing for dealing with loop points etc.

baconpaul commented 1 year ago

Gotcha, so let’s keep this pen as a probably forever from now if ever. but if we bring in the MSEG it might be interesting to remember this use case.

baconpaul commented 1 year ago

And now I understand it that is indeed a really nice visual representation of that feature

mkruselj commented 1 year ago

With MSEG, it would probably make more sense to draw the waveform of the leader zone faintly in the background, rather than hijack the Sample Editor view for this completely far away located feature on the UI. And make it optional too.

baconpaul commented 1 year ago

Yeah. and anyway no way we get there this year! But it’s interesting and I have been thinking about sc and percussion some as I do all this zone work so I think we should keep this open as an idea fermenter.